Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 335283

Summary: [Theming] Remove left-overs from property-based theming
Product: [RT] RAP Reporter: RĂ¼diger Herrmann <ruediger.herrmann>
Component: RWTAssignee: Project Inbox <rap-inbox>
Status: ASSIGNED --- QA Contact:
Severity: enhancement    
Priority: P3 CC: rsternberg
Version: 1.4   
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard:

Description RĂ¼diger Herrmann CLA 2011-01-25 04:32:13 EST
In Widget.theme.xml there is an "*" element alongside with a comment:
  Eliminate when property support is gone

As property-based theming isn't supported anymore (to my knowledge), can this element be removed?
Comment 1 Ralf Sternberg CLA 2011-01-25 05:27:26 EST
Yes, we should eliminate these remains, but we can't get rid of the "*" element right away since there are still a couple of references to it in the AppearancesBase.js. Those need to be replaced by the real element names before.

We should also get rid of Control.theme.xml and Control.default.css.
Comment 2 Ivan Furnadjiev CLA 2012-05-23 07:13:08 EDT
We recently had a problem with "*" CSS definitions in "business" and "fancy" themes. If an element is not defined in the theme (Table-RowOverlay in our case) it does not fallback to the "fallback" theme. Definitions from the asterisk selector are used instead, leading to weird appearance. Before we remove it, we have to ensure that it is not used in any appearance files and the corresponding CSS properties are added to every widget (font, background-color, background-image, color).