Bugzilla – Full Text Bug Listing
| Summary: | enhance search result handler to handle additional attributes | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | z_Archived | Reporter: | David Green <greensopinion> | ||||||||||
| Component: | Mylyn | Assignee: | David Green <greensopinion> | ||||||||||
| Status: | RESOLVED FIXED | QA Contact: | Frank Becker <eclipse> | ||||||||||
| Severity: | enhancement | ||||||||||||
| Priority: | P3 | CC: | eclipse, robert.elves | ||||||||||
| Version: | unspecified | ||||||||||||
| Target Milestone: | 3.5 | ||||||||||||
| Hardware: | PC | ||||||||||||
| OS: | Windows 7 | ||||||||||||
| Whiteboard: | |||||||||||||
| Attachments: |
|
||||||||||||
|
Description
David Green
Created attachment 187496 [details]
patch that adds support for additional columns
That sounds reasonable to me but I think the implementation of the patch could be improved. Are the additional tags standards Bugzilla tags? Why not add them to BugzillaAttribute? (In reply to comment #2) > That sounds reasonable to me but I think the implementation of the patch could > be improved. Are the additional tags standards Bugzilla tags? Why not add them > to BugzillaAttribute? Yes we should support all possible columns. Should we open an other bug for extend the BugzillaSearchPage to allow the selection of the columns. We can pass them columnlist= field in the queryurl? > Should we open an other bug for extend the BugzillaSearchPage to allow the
> selection of the columns.
> We can pass them columnlist= field in the queryurl?
Do you have ideas how to present that in the search result view? I am not sure that we would want to add columns there as it would potentially make the view more difficult to use, e.g. when searching with different connectors.
(In reply to comment #2) > That sounds reasonable to me but I think the implementation of the patch could > be improved. Are the additional tags standards Bugzilla tags? Why not add them > to BugzillaAttribute? The additional attributes are standard Bugzilla ones, however their name in BugzillaAttribute doesn't correspond to the name of the XML element returned in the search result, which is why they are handled specially. I assumed that changing the attribute name in BugzillaAttribute was a non-starter. I think that I found two other columns that need special cases: Bugzzilla UI -> BugzillaAttribute opendate -> creation_ts changeddate -> delta_ts Can someone verify! Created attachment 187782 [details]
mylyn/context/zip
(In reply to comment #4) > > Should we open an other bug for extend the BugzillaSearchPage to allow the > > selection of the columns. > > We can pass them columnlist= field in the queryurl? > > Do you have ideas how to present that in the search result view? I am not sure > that we would want to add columns there as it would potentially make the view > more difficult to use, e.g. when searching with different connectors. I think we should use TaskListToolTip to show the additional information. The Query is used to build the Tasklist to, so this a one place for both cases. Thoughts? > I think we should use TaskListToolTip to show the additional information. The
> Query is used to build the Tasklist to, so this a one place for both cases.
That way users would be able to configure additional fields to be displayed in the tooltip? It's an interesting idea but I wonder if the query UI will get even more complex.
(In reply to comment #9) > > I think we should use TaskListToolTip to show the additional information. The > > Query is used to build the Tasklist to, so this a one place for both cases. > > That way users would be able to configure additional fields to be displayed in > the tooltip? It's an interesting idea but I wonder if the query UI will get > even more complex. Yes but if we fix bug# 332304 we can build a new UI with TabFolder instead of ExpandableComposite with the following tabs: * Detail summery of all selected fields including column information * Basic * More * Charts * ResultColumns Thoughts? This bug was originally intended to improve the BuzillaClient class, for use in Java programs. Is it possible to work with this patch to improve it, get it integrated and then the UI discussion can continue? (In reply to comment #6) > I think that I found two other columns that need special cases: > > Bugzzilla UI -> BugzillaAttribute > opendate -> creation_ts > changeddate -> delta_ts The date columns are fomatted to omit the time portion, so they're not equivalent. Not sure about the other one. Can you add a test case to the patch David? Thanks David, I commit your patch. What is about an test case? I still owe you a test case. Created attachment 189643 [details]
a patch with unit test
Created attachment 189644 [details]
mylyn/context/zip
Should we leave this bug open for address the UI changes or do you think we better open an new bug? (In reply to comment #17) > Should we leave this bug open for address the UI changes or do you think we > better open an new bug? Let's resolve this and open a new bug to capture the discussion about proposed UI changes. Patches have been applied. |