Bugzilla – Full Text Bug Listing
| Summary: | compile errors with near M5 platform | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [WebTools] Java Server Faces | Reporter: | David Williams <david_williams> | ||||
| Component: | Core | Assignee: | Ian Trimble <ian.trimble> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | raghunathan.srinivasan | ||||
| Version: | unspecified | ||||||
| Target Milestone: | 3.3 | ||||||
| Hardware: | PC | ||||||
| OS: | Windows 7 | ||||||
| See Also: |
https://git.eclipse.org/r/114265 https://git.eclipse.org/c/jsf/webtools.jsf.git/commit/?id=d181c584f5da70b10f1878da4ca022514fd4a1c8 |
||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
Code previously added to address Bug 263806 relied on internal classes that have since been removed. Bug 263806 no longer requires the code that was added in order to function correctly, and so the old fix for Bug 263806 has simply been removed. This addresses "main" code issues - test fixes are still required. Platform resource changes necessitated updates to our mock resource test objects. Raghu, please review for PMC approval. I have successfully tested the failure to save from source tab scenario manually and have successfully run all JUnit tests that use the affected mock resource objects. My mistake, this is for 3.3, not 3.2.3 - no PMC approval required. Committed to HEAD (3.3 stream) at 2011/01/25 11:43AM PDT. It appears the fixes for 'test' code did not get released? http://build.eclipse.org/webtools/committers/wtp-R3.3.0-I/20110125225544/I-3.3.0-20110125225544/ Test changes also released. New Gerrit change created: https://git.eclipse.org/r/114265 Gerrit change https://git.eclipse.org/r/114265 was merged to [master]. Commit: http://git.eclipse.org/c/jsf/webtools.jsf.git/commit/?id=d181c584f5da70b10f1878da4ca022514fd4a1c8 |
Created attachment 187494 [details] compile log showing ERROR: in test bundle The build machine is currently hosed up ... but, in a local build, I see that moving up to latest platform build causes some compile errors. I tried moving to I20110118-0800 4 errors in "main" code seemed to all have to do with 'BaseSaveAction' no longer being around? (or, changed packages?) Source File: org/eclipse/jst/jsf/facesconfig/ui/FacesConfigEditor.java 1. ERROR: ImportNotFound The import org.eclipse.ui.internal.BaseSaveAction cannot be resolved FacesConfigEditor.java : 101 : import org.eclipse.ui.internal.BaseSaveAction; There were 15 more in a test plugin, for which I'll attach the compile log. Just wanted to give a little early warning ... especially since build machine is "dead" we likely won't get new build until Tuesday noonish, or so.