Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 335271

Summary:	Compile error with latest platform
Product:	[WebTools] WTP Webservices	Reporter:	David Williams <david_williams>
Component:	jst.ws.jaxws	Assignee:	Danail Branekov <danail.branekov>
Status:	CLOSED FIXED	QA Contact:	Shane Clarke <shane_clarke>
Severity:	blocker
Priority:	P3	CC:	danail.branekov
Version:	unspecified
Target Milestone:	---
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description David Williams

2011-01-24 22:04:17 EST

I've no idea if this is "real", but thought I'd report in case provides "early warning". 

I tried making a target using one of the latest platform builds, I20110118-0800, and got a compile error in 

/org.eclipse.jst.ws.jaxws.dom.integration/src/org/eclipse/jst/ws/jaxws/dom/integration/navigator/actions/OpenWSResourceAction.java

as pasted below. This was in my workspace. Having trouble getting a batch build to complete at all ... so there's no compiler output from that. 

From what I can tell, neither OpenWSResourceAction or IMarker have changed with respect to this method recently ... so, just reporting what the workbench says. 

= = = = = 

Description	Resource	Path	Location	Type
The method setAttributes(Map<String,Object>) in the type IMarker is not applicable for the arguments (HashMap<String,Integer>)	OpenWSResourceAction.java	/org.eclipse.jst.ws.jaxws.dom.integration/src/org/eclipse/jst/ws/jaxws/dom/integration/navigator/actions	line 150	Java Problem

Comment 1 David Williams

2011-01-25 14:37:59 EST

This is (still) an error with platform build from 
I20110124-1800

So will mark as blocking. Its easy to fix in our source. But if its something you think is not an error (or, shouldn't be) feel free to open a bug on platform team. Like I mentioned earlier, from what I can quickly see, nothings changed in our source from our previous builds (using M4 Platform) ... but ... maybe I'm looking at it wrong? 



Source File: org/eclipse/jst/ws/jaxws/dom/integration/navigator/actions/OpenWSResourceAction.java
    1. ERROR: ParameterMismatch

    The method setAttributes(Map<String,Object>) in the type IMarker is not applicable for the arguments (HashMap<String,Integer>)

    OpenWSResourceAction.java :

    150 : marker.setAttributes(map);

Comment 2 David Williams

2011-01-25 14:48:52 EST

actually I'll open a bug on platform ... see what they say. 
I suspect it is one of those changes that is "binary compatible" but not "source compatible"?

Comment 3 David Williams

2011-01-25 15:04:29 EST

I opened bug 335372. 

But, I suggest we make the minimal change in our code just to make sure we get a good compile soon. 

change
HashMap<String, Integer> map = new HashMap<String, Integer>();
to 
HashMap<String, Object> map = new HashMap<String, Object>();

Comment 4 David Williams

2011-01-25 15:36:07 EST

I've released the "quick fix" above so we get a clean compile with latest platform, but does appear we caught a "source level bug" for them :) 

For the record, if you want to revert, after Platform bug fixed, the previous map entry had 

org.eclipse.jst.ws.jaxws.dom.integration=v201004171919

You (we) might want to revert, for example, if there's no other changes that's been made to the containing features ... otherwise, their service fields will need to be incremented. 

But, I'll leave that to the "core" jaxws team to decide.

Comment 5 Shane Clarke

2011-01-25 16:17:44 EST

Thanks David for applying the fix.

It looks like the fix for Bug #335372 has been fixed and released. 

No need to revert i think. There have been additional changes to the containing feature. I'll update the service version fields.

Comment 6 Danail Branekov

2011-01-26 07:55:22 EST

Hi David,

You fix is the right thing to do. Therefore I am closing the bug as fixed