Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 335218

Summary:

Extension point for registering EObject, EPackage, model editor

Product:

z_Archived

Reporter:

Fabien Giquel <fabien.giquel>

Component:

EMF-Facet

Assignee:

Nicolas Bros <nicolas.bros>

Status:

CLOSED FIXED

QA Contact:

Severity:

enhancement

Priority:

CC:

emft.facet-inbox, gdupe, nicolas.bros

Version:

unspecified

Flags:

gdupe: indigo+

Target Milestone:

---

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
org.eclipse.emf.facet.emf.util.doc	nicolas.bros: iplog+
org.eclipse.emf.facet.util.emf.core.tests	nicolas.bros: iplog+

Description Fabien Giquel

2011-01-24 12:08:59 EST

Here is an entry for planned Indigo feature : providing some extension point which allows the user to register some editor/browser. Such an information will be used in some specific modeling feature (such as EPackage view, or MoDisco discovery feature).
Such editor is dedicated either to EPackage, EObject, or Resource input.

Comment 1 Fabien Giquel

2011-01-24 12:13:12 EST

This enhancement has been commited into SVN in org.eclipse.emf.facet.util.emf.ui (rev 252).
There are still improvments to do :
- try to move the extension point to org.eclipse.emf.facet.util.emf.core
- complete the preferences page

Comment 2 Fabien Giquel

2011-01-25 04:14:22 EST

Did not success in moving the extension point from
org.eclipse.emf.facet.util.emf.ui to org.eclipse.emf.facet.util.emf.core since
the registry class uses JFace IPreferenceStore interface. To go further
registry class should also be registered through some additional extension
point.

Comment 3 Fabien Giquel

2011-01-27 04:46:51 EST

Memo : On the aspect "try to move the extension point to org.eclipse.emf.facet.util.emf.core" we should try to use the API 
String text = Platform.getPreferencesService()

Comment 4 Nicolas Bros

2011-01-27 11:06:41 EST

Fixed in revision 3804.

To manipulate preferences, it uses InstanceScope, DefaultScope and ScopedPreferenceStore to adapt the InstanceScope to the FieldEditorPreferencePage.

Comment 5 Gregoire Dupe

2011-01-27 12:38:25 EST

Hi Nicolas,

Please, can you:
 - precise where to find the documentation,
 - precise where to find the unit tests,
 - add one line in the contributors list of each file you’ve modified,
 - add a readme file to explain why you expose an internal package (when this is the case).

Regards,
Gregoire

Comment 6 Nicolas Bros

2011-01-28 04:46:22 EST

I put the documentation in:
https://dev.eclipse.org/svnroot/modeling/org.eclipse.emft.facet/trunk/doc/org.eclipse.emf.facet.emf.util.doc

Committed in revision 263.

Comment 7 Nicolas Bros

2011-01-28 04:59:57 EST

Created attachment 187820 [details]
org.eclipse.emf.facet.emf.util.doc

attaching new doc plug-in (for IP log)

Comment 8 Nicolas Bros

2011-01-28 05:33:00 EST

Created attachment 187824 [details]
org.eclipse.emf.facet.util.emf.core.tests

I added a new test plug-in : org.eclipse.emf.facet.util.emf.core.tests.
Committed in revision 266.

Comment 9 Nicolas Bros

2011-01-31 10:04:27 EST

Marking as fixed.

Comment 10 Gregoire Dupe

2011-02-01 03:44:07 EST

Hello,

The plug-in org.eclipse.emf.facet.emf.util.doc is not correctly named: it should be named org.eclipse.emf.facet.util.emf.doc.

Regards,
Gregoire Dupe

Comment 11 Nicolas Bros

2011-02-01 04:06:41 EST

> The plug-in org.eclipse.emf.facet.emf.util.doc is not correctly named: it
> should be named org.eclipse.emf.facet.util.emf.doc.

Fixed in revision 272.

Comment 12 Gregoire Dupe

2011-06-06 11:37:25 EDT

This bug can be closed.

Comment 13 Gregoire Dupe

2011-06-06 11:37:37 EDT

This bug can be closed.