Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 335161

Summary:	Invalid toString() access for text retrieval in some JTableImplClass-actions
Product:	[Technology] Jubula	Reporter:	Markus Tiede <markus.tiede>
Component:	RC	Assignee:	Oliver Goetz <Oliver.Goetz>
Status:	CLOSED FIXED	QA Contact:	Oliver Goetz <Oliver.Goetz>
Severity:	major
Priority:	P3
Version:	unspecified
Target Milestone:	Indigo RC2
Hardware:	All
OS:	All
Whiteboard:

Description Markus Tiede

2011-01-24 05:05:19 EST

Some of our Swing implementation classes, such as the JTableImplClass actions, do currently not support the usage of custom renderer components: e.g. they access the components text directly by using "table.getValueAt(rowIndex, columnIndex).toString()".

Comment 1 Markus Tiede

2011-05-10 09:48:02 EDT

This problem is e.g. visible in JTableImplClass at line 664:

http://git.eclipse.org/c/jubula/org.eclipse.jubula.core.git/tree/org.eclipse.jubula.rc.swing/src/org/eclipse/jubula/rc/swing/swing/implclasses/JTableImplClass.java?id=640ccaa7f26a7a56bf52d7c10025b855264f8fa9#n664

Comment 2 Markus Tiede

2011-05-20 09:40:01 EDT

Fixed JTableImpl class cell text retrieval with

http://git.eclipse.org/c/jubula/org.eclipse.jubula.core.git/commit/?id=dd387275ca1cc343dd37482780ef1d50ad82e1ed

I also checked all other org.eclipse.jubula.rc.*-package implementation classes for toString() usage for text retrieval.

I also opened an enhancement for the (consistent) lack of custom renderer support for JTable headers see bug 346676 for further information.

Comment 3 Oliver Goetz

2011-07-26 07:24:32 EDT

Could you please do a code review of http://git.eclipse.org/c/jubula/org.eclipse.jubula.core.git/commit/?id=dd387275ca1cc343dd37482780ef1d50ad82e1ed and then assign this ticket to me.

Comment 4 Zeb Ford-Reitz

2011-07-26 08:35:12 EDT

The changeset itself looks fine. However, after looking through all references to JTable.getValueAt(int, int), I noticed that our RecordHelper also performs its own text retrieval. Although the text retrieval implemented in RecordHelper is correct, it looks like code duplication.

All of that being said, the changeset seems to resolve the issue encapsulated by this bug report: the incorrect usage of toString().

Comment 5 Oliver Goetz

2011-07-26 08:38:07 EDT

Closing ticket as fixed and tested.