Bugzilla – Full Text Bug Listing
| Summary: | web_ui.properties changed without proper approval | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [WebTools] WTP Java EE Tools | Reporter: | Masayuki Fuse <fuse> | ||||||
| Component: | jst.servlet | Assignee: | Roberto Sanchez Herrera <shr31223> | ||||||
| Status: | VERIFIED FIXED | QA Contact: | Chuck Bridgham <cbridgha> | ||||||
| Severity: | major | ||||||||
| Priority: | P2 | CC: | ccc, david_williams, kitlo, raghunathan.srinivasan | ||||||
| Version: | 3.2 | Flags: | david_williams:
pmc_approved+
raghunathan.srinivasan: pmc_approved+ ccc: pmc_approved? (naci.dai) ccc: pmc_approved? (deboer) ccc: pmc_approved? (neil.hauge) ccc: pmc_approved? (kaloyan) cbridgha: review+ |
||||||
| Target Milestone: | 3.2.3 | ||||||||
| Hardware: | PC | ||||||||
| OS: | Windows XP | ||||||||
| Whiteboard: | PMC_approved | ||||||||
| Bug Depends on: | 327802 | ||||||||
| Bug Blocks: | |||||||||
| Attachments: |
|
||||||||
Created attachment 187395 [details]
screen shot
Fuse-san, WTP does not provide translations for its content. You will need to figure out where you are getting your translation from, and contact the appropriate provider. This is bad. After further investigation (with Kit Lo's help), I discovered that bug 327802 changed the content of org.eclipse.jst.servlet.ui\web_ui.properties without proper PMC approval. This causes breakages in the UI of adopters. We need to "undo" the UI part of that change for the R3_2_maintenance stream. I am updating the description to properly reflect the problem. Created attachment 187450 [details]
Restore the content of org.eclipse.jst.servlet.ui\web_ui.properties
approved Please note that, while a properties file is being changed, there is no UI/NLS changes between WTP 3.2.2 and the properties file that will be released in WTP 3.2.3 if this change is approved. If the change is not approved, we will need to seek PMC approval for the NLS change that was previously made.
* Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug" (requested by an adopter) please document it as such.
This was a UI breakage that needs to be reverted, as it breaks translations of WTP by adopters (including IBM).
* Is there a work-around? If so, why do you believe the work-around is insufficient?
The work-around would be for all translations of WTP to change their properties files. That is not an acceptable option.
* How has the fix been tested? Is there a test case attached to the bugzilla record? Has a JUnit Test been added?
The UI was tested by hand to verify that the correct string is displayed.
* Give a brief technical overview. Who has reviewed this fix?
Roberto reverted the change made by another developer- the properties file is now the same as it was in WTP 3.2.0-3.2.2, and the proper, empty, string is now substituted. Chuck Bridgham and Carl Anderson have reviewed this fix.
* What is the risk associated with this fix?
Extremely low
thanks for catching (and fixing) this maintenance "break". Committed to R3_2_maintenance for WTP 3.2.3. Note that this will *NOT* be committed to HEAD, since it is perfectly acceptable to change a properties file like this before WTP 3.3 M6. (In reply to comment #8) > ... since it is perfectly > acceptable to change a properties file like this before WTP 3.3 M6. Yes, it is. But still ... sounds like a pretty "breaking change" if a translator doesn't notice or translated files not udpated? Its not like a word to end user is wrong ... but actually creates wrong folders? Are translations such as "babel" controlled so that "new version of translations" for every new release? Perhaps so, but perhaps deserves mention in our "migration guide"? (and I really do not know if this deserves so much attention ... just asking). >Are translations such as "babel" controlled so that "new version of translations" for every new release? Perhaps so, but perhaps deserves mention in our "migration guide"?
It's normal and acceptable to modify the UI strings between releases. Babel does extract all strings for every new release. I don't think this needs to be mentioned in the migration guide.
(In reply to comment #10) > >Are translations such as "babel" controlled so that "new version of translations" for every new release? Perhaps so, but perhaps deserves mention in our "migration guide"? > > It's normal and acceptable to modify the UI strings between releases. Babel > does extract all strings for every new release. I don't think this needs to be > mentioned in the migration guide. Excellent. Thanks for your expertise, Kit. Verified the fixed in M-3.2.3-20110127202034. Thanks |
Build Identifier: 3.2.2.v201101121727 + NPpack1-wtp-sdk-noop-R-3.2.2-2010091517344 Japanese folder label for "Java Resources" contains {0} Reproducible: Always Steps to Reproduce: 1. Create a Dynamic Web Project 2. Expand the project on the Project Explore view 3.