Bugzilla – Full Text Bug Listing
| Summary: | [discovery] NullPonterException when calling the discovery dialog in the EPP SOA 3.6.2 RC1 package | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Equinox | Reporter: | Zsolt Beothy-Elo <zsolt.beothy-elo> | ||||||||
| Component: | p2 | Assignee: | Pascal Rapicault <pascal> | ||||||||
| Status: | CLOSED FIXED | QA Contact: | |||||||||
| Severity: | critical | ||||||||||
| Priority: | P2 | CC: | dj.houghton, kpqb38, pascal, steffen.pingel, tjwatson | ||||||||
| Version: | unspecified | Flags: | tjwatson:
pmc_approved+
dj.houghton: review+ |
||||||||
| Target Milestone: | 3.6.2 | ||||||||||
| Hardware: | PC | ||||||||||
| OS: | Mac OS X - Carbon (unsup.) | ||||||||||
| Whiteboard: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Zsolt Beothy-Elo
Still happens in RC2 and apparently also in the pulsar package. THis should really be fixed before we get out 3.6.2. (In reply to comment #1) > Still happens in RC2 and apparently also in the pulsar package. THis should > really be fixed before we get out 3.6.2. For the pulsar problem see bug 33504 *** Bug 336077 has been marked as a duplicate of this bug. *** I'm not sure who owns the discovery code but I'm pretty sure it isn't Pascal. Let's leave it up to the component owners to decide if it should be fixed for Eclipse 3.6.2. (the RC2 build is today in an hour) Just forget comment #2 (In reply to comment #4) > I'm not sure who owns the discovery code but I'm pretty sure it isn't Pascal. > Let's leave it up to the component owners to decide if it should be fixed for > Eclipse 3.6.2. (the RC2 build is today in an hour) I don't know who is owning the code, but Pascal was the one doing the improvements in 3.7 and also incompletely applying them to the 3.6 line, which led to the NPE. So, I think he is the most competent to decide how to further proceed with th ebug. I'll take that one back. (In reply to comment #2) > (In reply to comment #1) > > Still happens in RC2 and apparently also in the pulsar package. THis should > > really be fixed before we get out 3.6.2. > For the pulsar problem see bug 336077. (In reply to comment #4) > I'm not sure who owns the discovery code but I'm pretty sure it isn't Pascal. > Let's leave it up to the component owners to decide if it should be fixed for > Eclipse 3.6.2. (the RC2 build is today in an hour) It is present in our RC2 build, and we would also like it fixed for RC3, if possible. We would be glad to help if we can. Created attachment 188334 [details]
fixed discovery bundle
Your analysis about the manifest is right on. I released a fix for this. Sorry about this.
Here is a binary version of the jar. To use it, hack the bundles.info file in your configuration to point at this file and you will be set.
Zsolt, Daniel, could you please confirm that the attached jar works for you. Thx. (In reply to comment #10) > Zsolt, Daniel, could you please confirm that the attached jar works for you. > Thx. Sort of, I have to first start the bundle explicitly in the console, because it's only in the resolved state. Then everything works fine. Otherwise I get the well-known NPE. (In reply to comment #11) > (In reply to comment #10) > > Zsolt, Daniel, could you please confirm that the attached jar works for you. > > Thx. > > Sort of, > I have to first start the bundle explicitly in the console, because it's only > in the resolved state. Then everything works fine. Otherwise I get the > well-known NPE. Same thing for us. :) Pascal, will this new version be available for Helios SR2 RC3 build then? And can we change our dependency to this version? Last but not least, thanks for the quick fix! Daniel Pastore Sequoyah Team Created attachment 188346 [details]
Take two
Second take at the fix, forgot to mark auto activate.
Closing again. (In reply to comment #13) > Created attachment 188346 [details] > Take two > > Second take at the fix, forgot to mark auto activate. Works fine now! And will it be version 1.0.1 on RC3? I'll change our dependency to use this version. Thanks again, Daniel Pastore Sequoyah Team Yes it will be version 1.0.1 (In reply to comment #14) > Closing again. Now also works for SOA package :) (In reply to comment #16) > Yes it will be version 1.0.1 Hi Pascal, Do you know when will this be on the composite repository? I tried updating the Pulsar package yesterday and I broke the build, since it still doesn't have the new version. :) (FYI, I already reverted it :) Thanks again for your attention, Daniel Pastore Sequoyah Team I agree this bug is critical and needs to be fixed. But ... It does not appear the necessary rules have been followed during the rampdown of SR2. I am not suggesting we backout the fixes, but we need to get a review of the changes (no patch on the bug report to review) and PMC approval. I have asked DJ to review the changes. I am willing to give approval after a review. I know we are running fast, but we still need to follow the rampdown process. (In reply to comment #19) > I agree this bug is critical and needs to be fixed. But ... > > It does not appear the necessary rules have been followed during the rampdown > of SR2. I am not suggesting we backout the fixes, but we need to get a review > of the changes (no patch on the bug report to review) and PMC approval. I have > asked DJ to review the changes. I am willing to give approval after a review. > > I know we are running fast, but we still need to follow the rampdown process. Alright, we agree too. Still, do you think it would be available for RC3? The packages are usually generated on late Thursday, but maybe we could ask EPP team for a little delay. Thanks for your attention, Daniel Pastore Sequoyah Team The changes appear to be incrementing the bundle version by 0.0.1 and adding the following lines to the manifest file: Bundle-Activator: org.eclipse.equinox.internal.p2.discovery.compatibility.Activator Bundle-ActivationPolicy: lazy (In reply to comment #20) > > Alright, we agree too. > Still, do you think it would be available for RC3? The packages are usually > generated on late Thursday, but maybe we could ask EPP team for a little delay. > > Thanks for your attention, > > Daniel Pastore > Sequoyah Team RC3 is done, we are in the middle of building RC4 right now. (In reply to comment #22) > (In reply to comment #20) > > > > Alright, we agree too. > > Still, do you think it would be available for RC3? The packages are usually > > generated on late Thursday, but maybe we could ask EPP team for a little delay. > > > > Thanks for your attention, > > > > Daniel Pastore > > Sequoyah Team > > RC3 is done, we are in the middle of building RC4 right now. Hi Thomas, When can we expect a build with this fix then? Since Equinox is has a +0 offset, it should be on next monday, right? If not, can we have a nightly build in the next day or two? Our concern is to test Pascal's fix in a Pulsar build ASAP, in order to mitigate the risk of not having a "quiet week" before GA. Thanks for your attention, Daniel Pastore Sequoyah Team We will have a build today, but that build is not being contributed to RC3. You should be able to test with today's build, but you are also correct that our final contribution for RC4 will happen on Monday. |