Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 335003

Summary: [Discoverer] : Existing Discoverers Refactoring based on new framework
Product: [Modeling] MoDisco Reporter: Fabien Giquel <fabien.giquel>
Component: InfrastructureAssignee: Nicolas Bros <nicolas.bros>
Status: CLOSED FIXED QA Contact:
Severity: enhancement    
Priority: P2 CC: gdupe, hugo.bruneliere, modisco.web-inbox, nicolas.bros
Version: 0.9.0Flags: fabien.giquel: indigo+
Target Milestone: 0.9.0 RC1   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Bug Depends on: 338437    
Bug Blocks:    
Attachments:
Description Flags
XML discoverer refactoring
none
XML discoverer patch v2
none
ejb-jar discoverer patch
none
XML discoverer patch v3
none
XML discoverer patch v4
none
XML discoverer patch v5
none
new project org.eclipse.modisco.xml.discoverer.ui
fabien.giquel: iplog+
XML discoverer patch v6
none
XML discoverer patch v7
none
org.eclipse.modisco.xml.discoverer.tests
fabien.giquel: iplog+
new project org.eclipse.modisco.jee.ejbjar.discoverer.ui
fabien.giquel: iplog+
new project org.eclipse.modisco.jee.webapp.discoverer.ui
fabien.giquel: iplog+
new plugin : org.eclipse.modisco.jee.jsp.discoverer.ui
fabien.giquel: iplog+
2 new plugins : org.eclipse.modisco.kdm.source.discoverer & UI fabien.giquel: iplog+

Description Fabien Giquel CLA 2011-01-21 07:29:55 EST
Here is an entry for a planned task in MoDisco Indigo roadmap : existing discoverers impelmentations (Java, JSP, XML, ...) must be refactored on the base of new Discovery Framework. Old implementations must go deprecated.
Comment 1 Nicolas Bros CLA 2011-02-08 05:51:00 EST
Created attachment 188505 [details]
XML discoverer refactoring

Here is a patch that adapts the XML discoverer to the new framework, and delegates the old discoverer to the new implementation and marks it deprecated.
Comment 2 Nicolas Bros CLA 2011-02-08 09:07:35 EST
Created attachment 188517 [details]
XML discoverer patch v2

The "silent" parameter is not meaningful in the context of the new discovery framework => removed from this new version of the patch.
Comment 3 Nicolas Bros CLA 2011-02-08 09:11:10 EST
Created attachment 188519 [details]
ejb-jar discoverer patch

Here is a patch with a refactoring of the ejb-jar discoverer on top of the new framework (but old discoverer doesn't delegate to the new one yet).
Comment 4 Nicolas Bros CLA 2011-02-09 07:38:49 EST
Created attachment 188583 [details]
XML discoverer patch v3

A new version of the patch, modified to adapt it to the latest version of the framework
Comment 5 Nicolas Bros CLA 2011-02-09 08:16:53 EST
Created attachment 188584 [details]
XML discoverer patch v4

rebased the patch on top of the latest version
Comment 6 Nicolas Bros CLA 2011-02-09 11:15:17 EST
Created attachment 188596 [details]
XML discoverer patch v5

- Split the plug-in in two : extracted the UI part into a new plug-in
- Use the discoverer's ResourceSet (from AbstractModelDiscoverer) to create the Resource
Comment 7 Nicolas Bros CLA 2011-02-09 11:16:08 EST
Created attachment 188597 [details]
new project org.eclipse.modisco.xml.discoverer.ui

UI part of the XML discoverer
Comment 8 Nicolas Bros CLA 2011-02-10 04:57:38 EST
Created attachment 188666 [details]
XML discoverer patch v6

This new patch handles Files as well as IFiles, to stay compatible with the old version of the discoverer.
Comment 9 Nicolas Bros CLA 2011-02-10 11:51:06 EST
Created attachment 188699 [details]
XML discoverer patch v7

old XML Discoverer : open model browser unless "silent" parameter is true, to keep the same behavior as before
Comment 10 Nicolas Bros CLA 2011-02-11 06:41:04 EST
Created attachment 188765 [details]
org.eclipse.modisco.xml.discoverer.tests

Here is a test project for the new XML discoverer.
I adapted the old tests to the new framework.
Comment 11 Nicolas Bros CLA 2011-02-14 11:55:36 EST
Created attachment 188912 [details]
new project org.eclipse.modisco.jee.ejbjar.discoverer.ui
Comment 12 Nicolas Bros CLA 2011-02-14 11:56:01 EST
Created attachment 188913 [details]
new project org.eclipse.modisco.jee.webapp.discoverer.ui
Comment 13 Nicolas Bros CLA 2011-02-16 09:43:59 EST
I committed in revision 3943 the refactoring of the JSP discoverer and its tests.
Comment 14 Nicolas Bros CLA 2011-02-16 09:45:26 EST
Created attachment 189098 [details]
new plugin : org.eclipse.modisco.jee.jsp.discoverer.ui

new plugin : org.eclipse.modisco.jee.jsp.discoverer.ui
(registers the JSP discoverer in the MoDisco menu)
Comment 15 Nicolas Bros CLA 2011-02-25 09:08:57 EST
Created attachment 189799 [details]
2 new plugins : org.eclipse.modisco.kdm.source.discoverer & UI

I refactored the KDM Source discoverer.
Comment 16 Nicolas Bros CLA 2011-02-28 11:38:50 EST
Bug 338437 is currently preventing me from creating a cell editor for selecting input projects/packages in the Java discoverer UI.
Comment 17 Fabien Giquel CLA 2011-03-25 06:49:22 EDT
kdm source discoverer : I committed some fix on checkstyle warning (rev 4184).
Comment 18 Fabien Giquel CLA 2011-05-06 02:49:49 EDT
No more work on this planned MoDisco framework evolution for Indigo.
Comment 19 Hugo Bruneliere CLA 2011-08-18 07:43:19 EDT
Refactoring done.