Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 334976

Summary:

[Webapp] file handle leaks in help system

Product:

[Eclipse Project] Platform

Reporter:

Rupesh Kumar <rukumar2>

Component:

User Assistance

Assignee:

platform-ua-inbox <platform-ua-inbox>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

cgold, ChrisAustin, rukumar2

Version:

3.7

Target Milestone:

3.7 M5

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
Fix for unclosed handle	cgold: iplog+

Description Rupesh Kumar

2011-01-21 01:53:32 EST

Build Identifier: 3.6.1

Help system is leaking file handles (opening file input streams and not explicitly closing them). We need to validate that file handles are being left open and provide a fix.

Reproducible: Sometimes

Comment 1 Rupesh Kumar

2011-01-21 01:55:13 EST

I have used the FindBugs a code analysis tool (free under GNU License), which really helped me to get the kind of code analysis I was looking.  To integrate FindBugs with Eclipse use the following link : http://findbugs.sourceforge.net/manual/eclipse.html. Very nice feature is that it provides the flexibility to select the individual bugs test e.g. OBL(description: Method may fail to clean up stream or resource) & OS (Description: Method may fail to close stream). To get more detailed description of the available bugs analysis using FindBugs refer : http://findbugs.sourceforge.net/bugDescriptions.html

Comment 2 Rupesh Kumar

2011-01-21 01:57:08 EST

Created attachment 187261 [details]
Fix for unclosed handle

I after running through FindBugs tool, I found one unclosed handle and I fixed it. Please find the fix in the patch.

Comment 3 Chris Goldthorpe

2011-01-21 17:10:41 EST

I reviewed your patch and it looks good. I will commit it next week.

Comment 4 Chris Goldthorpe

2011-01-21 17:27:07 EST

Patch committed to HEAD, Fixed