| Summary: | [Compatibility] Editor action bars should only be hidden when the editor is closed or a different type of editor has been activated | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] e4 | Reporter: | Dani Megert <daniel_megert> | ||||
| Component: | UI | Assignee: | Remy Suen <remy.suen> | ||||
| Status: | VERIFIED FIXED | QA Contact: | Remy Suen <remy.suen> | ||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | remy.suen | ||||
| Version: | 1.0 | ||||||
| Target Milestone: | 4.1 M5 | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
Editor actions (through the menu manager) were being removed when the part got deactivated. They should stay up if another view is activated. However, if a different type of editor gets activated (that being its action bar is not the same kind of editor as the one that was last activated), then those actions should be removed. Created attachment 187292 [details]
WorkbenchPage patch v1
Patch released to CVS HEAD. Is this bug supposed to be fixed in I20110121-1315? (In reply to comment #4) > Is this bug supposed to be fixed in I20110121-1315? Don't think so. Paul only submitted it yesterday. http://dev.eclipse.org/mhonarc/lists/e4-dev/msg04787.html There were issues with the Friday build and a new one was spun but it wasn't for actual code changes. > There were issues with the Friday build and a new one was spun but it wasn't > for actual code changes. Can you ping me with the build ID once this fix is in? When I download from http://download.eclipse.org/e4/sdk/ it takes very long (> 1 hour), hence I want to avoid downloading builds which don't contain the fixes I need to verify. BTW: Are there no N-builds for 4.1? (In reply to comment #6) > Can you ping me with the build ID once this fix is in? Will let you know after I get in the office in an hour or so. > BTW: Are there no N-builds for 4.1? No, we don't do N builds. (In reply to comment #6) > Can you ping me with the build ID once this fix is in? Hi Dani, please use this build to check. http://download.eclipse.org/e4/sdk/drops/I20110125-2200/index.php Thanks for helping us test 4.1! Verified in I20110125-2200. |
4.1 build: I20110118-1548. I couldn't find the pattern yet: some disabled menu items are shown while others don't show up. 1. start new workspace 2. paste "public class A {}" into Package Explorer 3. activate the 'Outline' view ==> 'Edit' menu is very small. For details compare the 'Edit' and other menus with 3.x. If the contributor added a menu then it should also be visible - even if disabled.