Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 334859

Summary: [Compatibility] Editor action bars should only be hidden when the editor is closed or a different type of editor has been activated
Product: [Eclipse Project] e4 Reporter: Dani Megert <daniel_megert>
Component: UIAssignee: Remy Suen <remy.suen>
Status: VERIFIED FIXED QA Contact: Remy Suen <remy.suen>
Severity: normal    
Priority: P3 CC: remy.suen
Version: 1.0   
Target Milestone: 4.1 M5   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
WorkbenchPage patch v1 none

Description Dani Megert CLA 2011-01-20 03:24:33 EST
4.1 build: I20110118-1548.

I couldn't find the pattern yet: some disabled menu items are shown while others don't show up.

1. start new workspace
2. paste "public class A {}" into Package Explorer
3. activate the 'Outline' view
==> 'Edit' menu is very small. For details compare the 'Edit' and other menus with 3.x.

If the contributor added a menu then it should also be visible - even if disabled.
Comment 1 Remy Suen CLA 2011-01-21 09:50:56 EST
Editor actions (through the menu manager) were being removed when the part got deactivated. They should stay up if another view is activated. However, if a different type of editor gets activated (that being its action bar is not the same kind of editor as the one that was last activated), then those actions should be removed.
Comment 2 Remy Suen CLA 2011-01-21 10:50:14 EST
Created attachment 187292 [details]
WorkbenchPage patch v1
Comment 3 Remy Suen CLA 2011-01-21 10:53:50 EST
Patch released to CVS HEAD.
Comment 4 Dani Megert CLA 2011-01-25 11:58:55 EST
Is this bug supposed to be fixed in I20110121-1315?
Comment 5 Remy Suen CLA 2011-01-25 12:07:48 EST
(In reply to comment #4)
> Is this bug supposed to be fixed in I20110121-1315?

Don't think so. Paul only submitted it yesterday.
http://dev.eclipse.org/mhonarc/lists/e4-dev/msg04787.html

There were issues with the Friday build and a new one was spun but it wasn't for actual code changes.
Comment 6 Dani Megert CLA 2011-01-26 02:42:00 EST
> There were issues with the Friday build and a new one was spun but it wasn't
> for actual code changes.
Can you ping me with the build ID once this fix is in? When I download from http://download.eclipse.org/e4/sdk/ it takes very long (> 1 hour), hence I want to avoid downloading builds which don't contain the fixes I need to verify.

BTW: Are there no N-builds for 4.1?
Comment 7 Remy Suen CLA 2011-01-26 06:14:13 EST
(In reply to comment #6)
> Can you ping me with the build ID once this fix is in?

Will let you know after I get in the office in an hour or so.

> BTW: Are there no N-builds for 4.1?

No, we don't do N builds.
Comment 8 Remy Suen CLA 2011-01-26 07:42:35 EST
(In reply to comment #6)
> Can you ping me with the build ID once this fix is in?

Hi Dani, please use this build to check.
http://download.eclipse.org/e4/sdk/drops/I20110125-2200/index.php

Thanks for helping us test 4.1!
Comment 9 Dani Megert CLA 2011-01-26 12:23:41 EST
Verified in I20110125-2200.