Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 334848

Summary:	define common coding conventions and formatting rules for Mylyn Reviews
Product:	z_Archived	Reporter:	Steffen Pingel <steffen.pingel>
Component:	Mylyn	Assignee:	Steffen Pingel <steffen.pingel>
Status:	RESOLVED FIXED	QA Contact:
Severity:	enhancement
Priority:	P3
Version:	unspecified
Target Milestone:	1.0
Hardware:	PC
OS:	Linux
URL:	http://dev.eclipse.org/mhonarc/lists/mylyn-reviews-dev/msg00291.html
Whiteboard:

Description Steffen Pingel

2011-01-19 22:48:08 EST

In order to ensure common coding conventions and to make it easy for contributors to submit patches that follow these conventions the Mylyn Reviews project should share project settings. The Mylyn project uses automatic formatting on save and a common set of compiler settings which have worked well in the past. Some of that process is documented here: http://wiki.eclipse.org/Mylyn/Contributor_Reference .

Comment 1 Steffen Pingel

2011-01-19 23:00:14 EST

I have pushed the settings that other Mylyn sub-projects use for the org.eclipse.mylyn.gerrit.* plug-ins.

Comment 2 Miles Parker

2012-12-11 14:24:59 EST

Is there anything left to do on this bug? R4E team have applied formatting under bug 391541. There is also closed bug 333807. One thing we should look at is applying formatting to and optimizing imports for generated EMF classes. It doesn't make sense for me to do that as a non-committer, but it would improve comparisons for future commits. (Please don't apply these while there are outstanding model reviews though!)

Comment 3 Steffen Pingel

2012-12-13 04:47:12 EST

This is indeed resolved. I have re-formatted the generated sources to ease future reviews.