Bugzilla – Full Text Bug Listing
| Summary: | Extending the Server Label Decorator | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [WebTools] WTP ServerTools | Reporter: | Israel Gomez Delgado <israelgd> | ||||
| Component: | wst.server | Assignee: | Angel Vera <arvera> | ||||
| Status: | CLOSED FIXED | QA Contact: | Angel Vera <arvera> | ||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | david_williams, eyuen7, kaloyan | ||||
| Version: | unspecified | Flags: | david_williams:
pmc_approved+
arvera: pmc_approved? (raghunathan.srinivasan) arvera: pmc_approved? (naci.dai) arvera: pmc_approved? (deboer) arvera: pmc_approved? (neil.hauge) kaloyan: pmc_approved+ arvera: review+ |
||||
| Target Milestone: | 3.2.3 | ||||||
| Hardware: | PC | ||||||
| OS: | All | ||||||
| See Also: | https://git.eclipse.org/r/109020 | ||||||
| Whiteboard: | PMC_approved | ||||||
| Attachments: |
|
||||||
|
Description
Israel Gomez Delgado
Created attachment 187152 [details]
v1.0
This patch adds the listener mechanism described in my previous comment.
The problem is caused by the existing ServerView2 only notify the UI label decorator that is provided by the WTP framework. In order to resolve that, we'll need to add a listener mechanism to allow other label decorators to listen to decorate changes whenever a refresh is needed. * Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug" (requested by an adopter) please document it as such. Although not a stop-ship, it prevent adopters from providing their decorators and having them work correctly * Is there a work-around? If so, why do you believe the work-around is insufficient? Although there might be possible workaround for adopters, a proper fix should be in WTP. * How has the fix been tested? Is there a test case attached to the bugzilla record? Has a JUnit Test been added? From what I understand (Elson can correct me), this was tested running with an adopter product that provided their own ServerDecorator using the platform server decorator extension point. * Give a brief technical overview. Who has reviewed this fix? I reviewed the fix offline and provided comments to make it safe. In the future we could improve the logic to make it more memory efficient by not cloning the list of decorators ids but rather ensure some synchronization that would work. * What is the risk associated with this fix? minimal, the testing didn't reveal any problem Yes, the testing is done on an adopter product on a custom ServerDecorator using the platform server decorator extension point. We should probably run a test to ensure that the changes work without an adopter extending it. But I agree with the changes and I am putting it for PMC approval. Israel send me an email letting me know that completed the testing as per my request and things look good. Changes committed to 32M waiting for PMC approval to release changes released to 32M still need to forward feed to HEAD Changes committed to HEAD Changes released to HEAD New Gerrit change created: https://git.eclipse.org/r/109020 |