Bugzilla – Full Text Bug Listing
| Summary: | Tomcat 7 requires a Java SDK in WTP | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [WebTools] WTP ServerTools | Reporter: | David Becker <david> | ||||
| Component: | jst.server | Assignee: | Larry Isaacs <larryisaacs> | ||||
| Status: | RESOLVED FIXED | QA Contact: | Angel Vera <arvera> | ||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | david, david_williams, larryisaacs, mauromol | ||||
| Version: | 3.2 | Flags: | david_williams:
pmc_approved+
arvera: pmc_approved? (raghunathan.srinivasan) arvera: pmc_approved? (naci.dai) arvera: pmc_approved? (deboer) arvera: pmc_approved? (neil.hauge) arvera: pmc_approved? (kaloyan) arvera: review+ |
||||
| Target Milestone: | 3.2.3 | ||||||
| Hardware: | PC | ||||||
| OS: | Mac OS X - Carbon (unsup.) | ||||||
| See Also: | https://git.eclipse.org/r/109019 | ||||||
| Whiteboard: | PMC_approved | ||||||
| Attachments: |
|
||||||
|
Description
David Becker
Larry Isaacs responded to a forum post with the following: That would be a bug. I missed updating that check when implementing the Tomcat 7 support. Of the numerous versions of Java I have on my system, they are almost all SDKs. Please file a bug report and I'll see about fixing that in WTP 3.2.3. If you create a file named tools.jar in the JRE's lib folder, that will work around this check. Cheers, Larry Updating product, component, and assigning to me. Created attachment 187137 [details]
Patch to include Tomcat 7.0 in the check for not requiring tools.jar
Angel, I would like to request this for WTP 3.2.3. Though perhaps not a "show-stopper" in the normal sense, it is a potential cycle waster as many more users start to trip over this with Tomcat 7.0 going "stable" with the recently released 7.0.6. The fix is simple and safe and fewer cycles to fix than to deal with the likely newgroup posts and possible bug reports about this issue. If you agree, I can add the PMC approval info. Thanks, Larry We need the PMC template Here is the PMC Approval Info: 1. Explain why you believe this is a stop-ship defect. This is a regression of Tomcat 7.0 behavior relative to Tomcat 5.5 and 6.0. For many years, Tomcat 5.5. and 6.0 have only needed a JRE, instead of an SDK (for tools.jar), because they use their own copy of the Eclipse Java compiler. Unfortunately, the checking to allow a JRE didn't get updated when Tomcat 7.0 support was added. As a result, Tomcat 7.0 is back to requiring an SDK, instead of a JRE, though a JRE is sufficient. Now that the recently released Tomcat 7.0.6 has been declared "stable", its use is going increase and many users are likely to trip over this. 2. Is there a work-around? If so, why do you believe the work-around is insufficient? Creating a "tool.jar" file in the JRE's lib folder will avoid the issue. However, users will be confused by this requirement and this trick is not obvious from the message displayed. WTP newsgroup posts, and perhaps duplicate bug reports, will likely occur. It would be better to avoid the grief and time answering newsgroup posts by implementing the simple fix for this. 3. How has the fix been tested? Is there a test case attached to the bugzilla record? Has a JUnit Test been added? I have manually testing the fix in my development environment. The Tomcat JUnits can detect this bug, but the warning is currently accepted as passing. Making this a failure would impose requirements it on the testing environment (have to run with a JRE) that probably aren't worth it. The JUnits can test any Tomcat version, but only one version in any one build. We continue to run the tomcat.core tests using Tomcat 5.0 at this time. 4. Give a brief technical overview. Who has reviewed this fix? The check that allows a JRE to be used for Tomcat 5.5 and 6.0 needs a minor update to include 7.0 too. 5. What is the risk associated with this fix? The change is simple enough to carry very little risk. Fix release to WTP 3.2.3 maintenance and HEAD and is present in current builds. New Gerrit change created: https://git.eclipse.org/r/109019 |