Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 334797

Summary:	Extend AbstractTaskReference and provide default impl
Product:	z_Archived	Reporter:	Benjamin Muskalla <b.muskalla>
Component:	Mylyn	Assignee:	Benjamin Muskalla <b.muskalla>
Status:	ASSIGNED ---	QA Contact:
Severity:	enhancement
Priority:	P3	CC:	caniszczyk, steffen.pingel
Version:	unspecified
Target Milestone:	---
Hardware:	PC
OS:	Linux
Whiteboard:

Description Benjamin Muskalla

2011-01-19 10:46:31 EST

Currently I'm struggeling with two things for 334631: [mylyn] integrate Open Corresponding Task into History view
https://bugs.eclipse.org/bugs/show_bug.cgi?id=334631

* LinkedTaskInfo is internal
* AbstractTaskReference doesn't have a notion of providing changed files (eg. Add to Context on a commit)
* Even with using the internal LinkedTaskInfo, I'm tied to return a ChangeSet implementation which is not really what Mylyn needs. It would be good to replace getChangeset with getResources and move it up to AbstractTaskReference.
* Hide "Add to context" menu when the reference doesn't provide any.

Can work on a patch for this if it makes sense to you.

Comment 1 Steffen Pingel

2011-01-19 22:38:16 EST

Agreed. The current  API is not very extensible and should be based on resources rather than AbstractTaskReference. Let's discuss that on a call before we dive into the implementation. I don't have any straight forward ideas how we can best do this.

Comment 2 Chris Aniszczyk

2011-02-03 09:12:02 EST

Would be nice to see this in the next release.

Comment 3 Steffen Pingel

2011-02-03 16:21:10 EST

Benjamin, can you join next weeks Mylyn call to discuss? I have added it to the agenda.

Comment 4 Benjamin Muskalla

2011-02-10 14:49:58 EST

After the discussion on the call today, we need to find the right place to host this adapter. As Versions should not depend on Tasks, we would need to move AbstractTaskReference and a new default implementation to Versions (or create new API if you want to call it like that).

Steffen, if you want, I can take a first pass on this beginning next week.

Comment 5 Steffen Pingel

2011-04-13 16:15:44 EDT

That sound good to me. Benjamin, will you have time to look into this?

Comment 6 Benjamin Muskalla

2011-04-13 18:47:09 EDT

Let's make time for it :)

Comment 7 Steffen Pingel

2011-05-16 13:19:50 EDT

Benjamin, to get this into 3.6 / Indigo we would need a patch by tomorrow. Is that realistic?

Comment 8 Benjamin Muskalla

2011-05-16 13:24:57 EDT

Not really. Let's do this after Indigo. I want to ensure that the API we do here is not some hectic last-day activity.