Bugzilla – Full Text Bug Listing
| Summary: | MPC needs to be updated to p2 transport refactoring | ||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Technology] MPC | Reporter: | Pascal Rapicault <pascal> | ||||||||||||||||
| Component: | Install | Assignee: | Benjamin Muskalla <b.muskalla> | ||||||||||||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||||||||||||
| Severity: | blocker | ||||||||||||||||||
| Priority: | P2 | CC: | b.muskalla, contact, eclipse, fonduee, greensopinion, iman760, kai.toedter, remy.suen | ||||||||||||||||
| Version: | unspecified | ||||||||||||||||||
| Target Milestone: | 1.1 | ||||||||||||||||||
| Hardware: | All | ||||||||||||||||||
| OS: | All | ||||||||||||||||||
| Whiteboard: | |||||||||||||||||||
| Attachments: |
|
||||||||||||||||||
|
Description
Pascal Rapicault
Thanks Pascal. From what I can see @org.eclipse.equinox.internal.p2.repository.RepositoryTransport@ has moved to a bundle with symbolic name @org.eclipse.equinox.p2.repository.impl@ Is there any chance of p2 transport code becoming API? (ie: RepositoryTransport) Created attachment 187135 [details]
mylyn/context/zip
We currently have no plan to make an official API around Transport, however know that we will try to treat the class org.eclipse.equinox.internal.p2.repository.Transport as such (or at least try to minimize the breakages). To access it (in 3.7) you will have to look up an actual implementation using a p2 agent instance. (In reply to comment #3) Thanks for the heads-up Pascal. *** Bug 337318 has been marked as a duplicate of this bug. *** Created attachment 189250 [details]
draft fix
I've drafted a possible fix to this problem. Note that the @Eclipse36TransportFactory@ will probably need compiling against the version of p2 that shipped with Eclipse 3.6. In that case, we can commit the class file for that class only.
Created attachment 189251 [details]
mylyn/context/zip
Hit this today while testing Indigo MPC on 4.1. :) *** Bug 337638 has been marked as a duplicate of this bug. *** Created attachment 189846 [details]
patch
David, here is my suggested patch for this. This compiles and runs against 3.6,3.7 and 4.1. I refactored your code pretty much but pattern remains the same. I moved several methods up into the Factory to share them between the implementations.
Created attachment 189847 [details]
mylyn/context/zip
I've applied the patch with some changes. Notably, I've moved any compile-time dependencies on p2 internals out of the TransportFactory class in case things change again in the future. Benjamin can you take this for a spin on both platforms? If it looks good to you, please resolve this task. Created attachment 189870 [details]
fix
David, you missed one change of the initial patch in the ProvisioningJobListener to use the new TransportFactory.
Patch applied, thanks Benjamin. I missed that part (the patch didn't apply cleanly) Created attachment 190090 [details]
mylyn/context/zip
*** Bug 335812 has been marked as a duplicate of this bug. *** How to apply this fix? The fix is already part of the current MPC HEAD and will be released together with the next build for indigo (next Wednesday). |