Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 334656

Summary:	Move p2 features to proper repository location
Product:	[Eclipse Project] Equinox	Reporter:	DJ Houghton <dj.houghton>
Component:	p2	Assignee:	DJ Houghton <dj.houghton>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	jeffmcaffer, kim.moir, pascal, pwebster
Version:	3.7
Target Milestone:	3.7 M6
Hardware:	PC
OS:	Mac OS X - Carbon (unsup.)
Whiteboard:

Description DJ Houghton

2011-01-18 10:23:46 EST

When we first started moving the builds to use p2 we created some temporary features to be used at different stages during the build. (agent, director, etc)  These features are stored in the repository as folders inside the p2.releng project.

Now that the build process is more defined and refined, we should move any applicable features to their proper location at:
  /cvsroot/rt/org.eclipse.equinox/p2/features

Comment 1 DJ Houghton

2011-01-18 10:34:56 EST

Currently these are the features which are in the releng project:

org.eclipse.equinox.p2.agent.feature
org.eclipse.equinox.p2.director.feature
org.eclipse.equinox.p2.generator.feature
org.eclipse.equinox.p2.user.ui

We should move at least org.eclipse.equinox.p2.user.ui. 

Kim, are any of the other features still used as part of the build?

Comment 2 Kim Moir

2011-01-18 10:44:34 EST

Only org.eclipse.equinox.p2.user.ui is included as part of the build. The other features are old and can be deleted. They haven't been used since 3.4/3.5.

Comment 3 Jeff McAffer

2011-01-18 11:06:44 EST

when you say moved/deleted, do we need to keep the history around in that spot so that old builds can be reproduced?  

Unless we really can delete them completely we should copy the content to a new spot (if needed) and then clean out HEAD and leave a readme.txt pointing to the new location.

Comment 4 DJ Houghton

2011-01-18 11:08:30 EST

(In reply to comment #3)
> Unless we really can delete them completely we should copy the content to a new
> spot (if needed) and then clean out HEAD and leave a readme.txt pointing to the
> new location.
>

Agreed. This is what I was planning on doing.

Comment 5 Kim Moir

2011-01-18 11:15:00 EST

Yes, please keep the history.

Comment 6 DJ Houghton

2011-01-28 16:55:53 EST

I've moved the user.ui feature to the p2/features folder and deleted the buildtime-features folder.
I updated the feature.map file and tagged in case there is a surprise i-build.

Comment 7 Jeff McAffer

2011-01-28 17:17:48 EST

Thanks DJ.  

I gotta ask just in case.  when you say "deleted..." you mean cleared out the content of HEAD right?  old builds that were using that location will continue to work right?

Comment 8 DJ Houghton

2011-01-28 17:29:15 EST

yep, "deleted" in the CVS Sync view. Didn't log into any server or move files, etc. All the history is still in the old location.