Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 334643

Summary:	[celleditors] cell editors get disposed automatically
Product:	z_Archived	Reporter:	Nicolas Bros <nicolas.bros>
Component:	EMF-Facet	Assignee:	Nicolas Bros <nicolas.bros>
Status:	CLOSED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	emft.facet-inbox, fabien.giquel, gdupe
Version:	unspecified	Flags:	gdupe: indigo+
Target Milestone:	---
Hardware:	All
OS:	All
Whiteboard:

Description Nicolas Bros

2011-01-18 09:05:06 EST

Some cell editors dispose their control automatically under some circumstances.

For example, StringMultiComposite disposes its control when the user hits Escape or cancels its dialog.

This behavior is disruptive when the cell editors are used directly in a dialog.
This causes the control to disappear from the dialog, rendering the dialog unusable until it is reopened.

Comment 1 Fabien Giquel

2011-01-18 15:26:32 EST

I observed and confirm the problem when using the StringMultiComposite composite from discoverers launch configs.

Comment 2 Nicolas Bros

2011-01-21 05:37:44 EST

Fixed in revision 248: I removed the calls to dispose() when hitting cancel in the dialog or trying to commit an invalid value.

The Composite still disposes itself on Escape, but this is not a problem for now, since Escape also closes the dialog at the same time.

Comment 3 Gregoire Dupe

2011-06-08 11:01:31 EDT

Nicolas B.,

I’m not able to close this bug because there isn’t any scenario to reproduce this bug and I do not remember the problem.

If you remember the problem can you check the fix and closed this bug.

Regards,
Gregoire

Comment 4 Nicolas Bros

2012-05-23 08:50:33 EDT

This works now : I'm marking this bug as closed.