Bugzilla – Full Text Bug Listing
| Summary: | fix warnings | ||
|---|---|---|---|
| Product: | [Modeling] MoDisco | Reporter: | Nicolas Bros <nicolas.bros> |
| Component: | Main | Assignee: | Project Inbox <modisco.web-inbox> |
| Status: | NEW --- | QA Contact: | |
| Severity: | trivial | ||
| Priority: | P5 | CC: | gdupe |
| Version: | 0.9.0 | ||
| Target Milestone: | --- | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
I committed fixes for many warnings in revision 3749. But there are still about 1500 warnings left in MoDisco code: 303 in org.eclipse.gmt.modisco.kdm.browser.extension 270 in org.eclipse.gmt.modisco.usecase.simpletransformationschain 153 in org.eclipse.gmt.modisco.usecase.modelfilter.methodcalls 142 in org.eclipse.gmt.modisco.java.nousages.cdo 119 in org.eclipse.gmt.modisco.workflow 76 in org.eclipse.gmt.modisco.java.generation 29 in org.eclipse.gmt.modisco.usecase.modelfilter.dependencies 28 in org.eclipse.gmt.modisco.kdm.uml2converter 27 in org.eclipse.gmt.modisco.infra.prefuse 27 in org.eclipse.gmt.modisco.usecase.modelfilter 15 in org.eclipse.modisco.jee.jsp.generation 11 in org.eclipse.gmt.modisco.java.discoverer.benchmark 10 in org.eclipse.gmt.modisco.kdm.source.discoverer 09 in org.eclipse.gmt.modisco.infra.discoverymanager ... We will focus on the move to EMF Facet before to take care of warnings => P5. |
When all Java warnings are enabled together with Checkstyle, there are many warnings. These should be fixed. For generated code (by EMF or Acceleo for example) where we can't fix the generator, we should disable the warnings. For projects containing only generated code, the warnings can be deactivated at the project level. For packages containing only generated code, the checkstyle warnings can be deactivated at the package level (by specifying a rule in the project's .checkstyle file). For projects that contain some generated classes together with hand-written code, we don't want to disable the warnings because they are still useful for the non-generated code. In this case, we can add @SuppressWarnings("all") on the generated classes.