Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 334555

Summary:

[Tooling] Deprecate log-level combo box in launcher

Product:

[RT] RAP

Reporter:

Tim Buschtoens <tbuschto>

Component:

Tools

Assignee:

Project Inbox <rap-inbox>

Status:

CLOSED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

beyhan.veliev, tbuschto

Version:

1.4

Target Milestone:

1.4 M6

Hardware:

All

OS:

All

Whiteboard:

Bug Depends on:

328107

Bug Blocks:

336242

Attachments:

Description	Flags
Version 1	none
Version 2	holger.staudacher: iplog+

Description Tim Buschtoens

2011-01-17 12:50:53 EST

After removing the qooxdoo logging implementation, the combo box in the lauchner is obsolete.

Comment 1 Beyhan Veliev

2011-02-03 09:58:19 EST

Created attachment 188237 [details]
Version 1

Provided patch removes the qooxdoo logging functionality included into RAP-tooling. Test cases has been updated also.

Comment 2 Rüdiger Herrmann

2011-02-05 08:16:48 EST

Not sure from when on we can remove the log-level UI . It might be that users will use 'new' tooling to develop RAP applications based on 1.3 (where the log-leve is still working).
In the meantime, we could append a text right to the combo that indicates that this setting is only applies to runtimes < 1.4 M5

Or am I too precautios, what do you think?

Comment 3 Ralf Sternberg

2011-02-08 19:36:54 EST

Of course, you're right. With bug 334913, you can even install an 1.3 runtime using the 1.4 tooling, before the release of 1.4.

Would the 1.3 runtime be unusable without this option? The default log level is OFF, that means if we removed this option, the 1.3 runtime would not even render error messages, right? Whereas in the current 1.4 runtime, we changed a lot of "this.error()" occurrences to "throw new Error()" - is this correct, Tim?

If so, should we then retain the option for 1.4?

Comment 4 Beyhan Veliev

2011-02-10 08:12:44 EST

Created attachment 188679 [details]
Version 2

>If so, should we then retain the option for 1.4?
The decision was to retain the option for 1.4. The provided patch decorates the log level combo box with a warning which informs the user that log level is not supported in RAP 14.

Comment 5 Holger Staudacher

2011-02-10 08:28:47 EST

I like this approach a lot. I modified your patch a little (formating and naming) and committed it to CVS HEAD. Good job!