Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 334438

Summary:

Disable the Cancel button in Project Facets dialog

Product:

[WebTools] WTP Common Tools

Reporter:

Roberto Sanchez Herrera <shr31223>

Component:

Faceted Project Framework

Assignee:

Konstantin Komissarchik <konstantin>

Status:

RESOLVED FIXED

QA Contact:

Konstantin Komissarchik <konstantin>

Severity:

enhancement

Priority:

CC:

ccc

Version:

unspecified

Target Milestone:

3.3 M5

Hardware:

OS:

Windows XP

Whiteboard:

Usability

Attachments:

Description	Flags
Disable Cancel button	konstantin: iplog+

Description Roberto Sanchez Herrera

2011-01-14 17:36:29 EST

Build Identifier: WTP M-3.2.3-20110113194837

The Cancel button in the Project Facets dialog does not revert changes when pressed, so the result is the same as if OK is pressed. This behavior is misleading, so disabling the Cancel button is proposed.

More details can be found here: 
http://www.eclipse.org/forums/index.php?t=rview&goto=639262#msg_639262

Reproducible: Always

Steps to Reproduce:
1.Open any new project wizard (new dynamic web project, EJB project, etc.)
2.Click on Modify...
3.Select any facet
4.Click Cancel. 
5.Click on Modify... again. The facet you selected in step 3 is still selected.

Comment 1 Roberto Sanchez Herrera

2011-01-14 17:42:47 EST

Created attachment 186857 [details]
Disable Cancel button

Comment 2 Konstantin Komissarchik

2011-01-19 13:09:34 EST

Thanks for your contribution. I have released the patch into 3.3 M5 stream.

Comment 3 Carl Anderson

2011-01-19 14:53:03 EST

Konstantin, is there a chance that we could get this into WTP 3.2.3?  I know it would require PMC approval, since it is a UI/"behavior" change (but really isn't, since Cancel doesn't cancel), but I also see it as a much needed usability improvement.

Comment 4 Konstantin Komissarchik

2011-01-19 14:56:04 EST

Doesn't seem like a big deal to me, but if you think it makes sense to put this in 3.2.3, I don't have any objections either. Feel free to raise for approval. If approved, I will do the backport.