| Summary: | Source hover is sometimes imprecise | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Tools] CDT | Reporter: | Marc-André Laperle <malaperle> | ||||
| Component: | cdt-editor | Assignee: | Anton Leherbauer <aleherb+eclipse> | ||||
| Status: | RESOLVED FIXED | QA Contact: | Anton Leherbauer <aleherb+eclipse> | ||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | cdtdoug, yevshif | ||||
| Version: | 7.0.1 | ||||||
| Target Milestone: | 7.0.2 | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
Also, if you hover on Bar (left of 'object') the source is displayed entirely. Created attachment 186866 [details]
Source Hover, adjust start and end for composite types
This patch contains two small changes to fix both cases. Is there any test for source hover? I didn't find any.
> This patch contains two small changes to fix both cases. Is there any test for
> source hover? I didn't find any.
Thanks, the patch looks good. Unfortunately we don't have automated tests for the Source Hover so manual testing must do for now.
Committed to cdt_7_0 and HEAD.
*** cdt cvs genie on behalf of aleherbau *** Bug 334405 - Source hover is sometimes imprecise Patch by Marc-Andre Laperle [*] CSourceHover.java 1.43.2.3 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/text/c/hover/CSourceHover.java?root=Tools_Project&r1=1.43.2.2&r2=1.43.2.3 [*] CSourceHover.java 1.47 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt-core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/text/c/hover/CSourceHover.java?root=Tools_Project&r1=1.46&r2=1.47 |
Tested with 7.0.1 and 8.0.0.201101140002. class Bar; void foo() { if(1) { ; ; ; ; ; ; } Bar object; } Hover on 'object', notice how the hover only displays the if statement. If you click in the hover window and scroll then you see 'Bar object'.