Bug 334353

Description Martin JANDA 2011-01-14 03:52:00 EST

Build Identifier: 2.2 revision 8831 - 01/14/2011 03:10 AM

DatabaseField.setIndex is never called in methods:
*) public Object get(DatabaseField key)
*) public Object getIndicatingNoEntry(DatabaseField key)

--- Original code
        index = this.fields.indexOf(key);
        if (index >= 0) {
            // PERF: If the fields index was not set, then set it.
            if (index == -1) {
                key.setIndex(index);
            }
            return this.values.get(index);
        } else {
            return null;
        }

--- Intended code
        index = this.fields.indexOf(key);
        if (index >= 0) {
            // PERF: If the fields index was not set, then set it.
!            if (key.getIndex() == -1) {
                key.setIndex(index);
            }
            return this.values.get(index);
        } else {
            return null;
        }

--- Impact
Access to record values are made through DatabaseFields with index already set.

According to my observation 'setIndex' should be called in ParameterExpression and in AbstractTransformationMapping.

Reproducible: Always