Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 334337

Summary: [diagram] clean separation necessary between parts and rendering
Product: z_Archived Reporter: Konstantin Komissarchik <konstantin>
Component: SapphireAssignee: Shenxue Zhou <shenxue.zhou>
Status: CLOSED FIXED QA Contact:
Severity: major    
Priority: P3    
Version: unspecified   
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard:
Bug Depends on:    
Bug Blocks: 334342    
Attachments:
Description Flags
Separate Diagram parts from Graphiti Rendering engine konstantin: iplog+

Description Konstantin Komissarchik CLA 2011-01-13 20:48:42 EST
UI parts classes in ui.diagram.editor package have dependencies on Graphiti. This need to be fixed. The parts hierarchy cannot have a dependency on any rendering technology. 

We need to be able to move ui.diagram.graphiti.* packages into a separate plugin and remove sapphire.ui dependency on gef and graphiti. The diagram definition classes and parts would stay in the main sapphire.ui plugin.
Comment 1 Shenxue Zhou CLA 2011-01-25 18:05:55 EST
Created attachment 187591 [details]
Separate Diagram parts from Graphiti Rendering engine
Comment 2 Shenxue Zhou CLA 2011-01-26 13:12:10 EST
The patch removes dependency on Graphiti from various sapphire diagram parts. The Graphiti based diagram editor now listens to model update events broadcast-ed by the diagram parts and diagram part templates and update the diagram accordingly.
Comment 3 Konstantin Komissarchik CLA 2011-01-27 03:25:30 EST
Patch not yet committed...
Comment 4 Konstantin Komissarchik CLA 2011-01-27 03:26:03 EST
Patch released.
Comment 5 Konstantin Komissarchik CLA 2011-06-09 16:35:08 EDT
This can be considered verified by observing that the main sapphire.ui plugin does not depend on graphiti or gef. Closing.