Bugzilla – Full Text Bug Listing
| Summary: | [server] Compile errors against egit 10.1 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | Andrew Niefer <aniefer> | ||||||
| Component: | Client | Assignee: | Tomasz Zarna <tomasz.zarna> | ||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||
| Severity: | normal | ||||||||
| Priority: | P3 | CC: | bokowski | ||||||
| Version: | 0.2 | ||||||||
| Target Milestone: | 0.2 | ||||||||
| Hardware: | PC | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Attachments: |
|
||||||||
I'm surprised that we have a dependency on egit - shouldn't we be using only jgit? Please take my comment with a grain of salt.. I don't actually know what's part of egit but assumed jgit was the implementation of Git and egit added the Eclipse (desktop) integration. (In reply to comment #0) > When compiling against egit 10.1 which was published over the christmas break. jgit/egit API is pretty vibrant, so to avoid situations like this I had added specific versions of org.eclipse.jgit and org.eclipse.egit.core to our previous repository. These dependencies were not moved to dev.eclipse.org, which resulted in the compilation error you see. I'll update GitFileStore so it compiles against the latest jgit/egit source. (In reply to comment #1) > jgit was the implementation of Git and egit added the Eclipse (desktop) integration. That's correct, but there is no API in jgit that would allow me to clone a repo as easy as the CloneOperation from egit.core does. However, I'm aware that the dependency is no good, so I'll prepare our own implementation of egit's CloneOperation (which basically does init, fetch and checkout, all can be done with jgit API). When done I'll remove the dep on egit, leaving the one on jgit only. Created attachment 186817 [details] Fix v01 (In reply to comment #2) > I'll update GitFileStore so it compiles against the latest jgit/egit source. Fix for the above. I managed to self-host and link to a git repo with the patch. I did even run some tests after I fixed bug 334365 on my side. I don't have commit right sto e4 yet so the patch will have to wait here for a while. Created attachment 186818 [details]
mylyn/context/zip
I released the patch for you Tomasz, the build ran to completion. (In reply to comment #2) > [...] I'll prepare our own implementation of egit's CloneOperation [...] > When done I'll remove the dep on egit, leaving the one on jgit only. Filed bug 334503. (In reply to comment #5) > I released the patch for you Tomasz, the build ran to completion. Thanks, sorry for the trouble. |
There are currently compile errors in org.eclipse.orion.server.filesystem.git/src/org/eclipse/orion/server/filesystem/git/GitFileStore.java When compiling against egit 10.1 which was published over the christmas break. [javac] 1. ERROR in /web/builds/I201101131656/plugins/org.eclipse.orion.server.filesystem.git/src/org/eclipse/orion/server/filesystem/git/GitFileStore.java (at line 421) [javac] final CloneOperation op = new CloneOperation(uri, true, null, [javac] workdir, "refs/heads/master", "origin", 0); [javac] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [javac] The constructor CloneOperation(URIish, boolean, null, File, String, String, int) is undefined