Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 334318

Summary: [client] Double login prompt is bad
Product: [ECD] Orion Reporter: Boris Bokowski <bokowski>
Component: ClientAssignee: Malgorzata Janczarska <malgorzata.tomczyk>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: eclipse.felipe, susan, Szymon.Brandys, tomasz.zarna
Version: 0.2   
Target Milestone: 0.2   
Hardware: PC   
OS: All   
Whiteboard:

Description Boris Bokowski CLA 2011-01-13 16:05:08 EST 
When I go to http://localhost:8080 to access Orion, I get a login dialog that I start to fill out, but while I am doing that, the page is reloaded (going to /navigate-table.html) and I have to start typing my login and password again.

This makes us look really bad.

I see two possible solutions:

1. Always go to /navigate.html without checking the preferences, i.e. without requiring any authentication at all.
2. Wait on the main page (index.html) until the user has logged in, and only once that is done, forward to the appropriate navigation page.

To do 2., we would probably have to change the dojo.addOnLoad(...) in index.html to something like orion.onLoggedIn(...).

Any opinions?
Comment 1 Szymon Brandys CLA 2011-01-14 04:32:12 EST 
Right, that's pain/ Especially when you start typing your credentials and the page is reloaded. I think we should handle redirecting on the server side, instead of doing that in a browser. Gosia will surely have some ideas how to solve it :-)
Comment 2 Malgorzata Janczarska CLA 2011-01-25 11:05:40 EST 
I've chosen option nr 2. The problem was that even on error confirmation was send to the same function. At this level there was no way to verify if the user property is not set, or if it cold not be retrieved. I added an optional second attribute to the "get" service function that indicates a function that should be notified on error. If this attribute is not added onDone() function is notified as it was before. This way it is safe for current use of the service.