Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 334299

Summary:	'Web Page Editor' implements IEditorSite interface which is tagged with @noimplement
Product:	[WebTools] Java Server Faces	Reporter:	Remy Suen <remy.suen>
Component:	UI	Assignee:	Ian Trimble <ian.trimble>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	pwebster, raghunathan.srinivasan, thatnitind
Version:	3.3
Target Milestone:	3.4.0
Hardware:	All
OS:	All
Whiteboard:
Bug Depends on:
Bug Blocks:	334303

Description Remy Suen

2011-01-13 13:34:29 EST

java.lang.NullPointerException
	at org.eclipse.ui.internal.KeyBindingService.registerAction(KeyBindingService.java:341)
	at org.eclipse.jst.pagedesigner.editors.SimpleGraphicalEditor.createActions(SimpleGraphicalEditor.java:279)
	at org.eclipse.gef.ui.parts.GraphicalEditor.initializeActionRegistry(GraphicalEditor.java:362)
	at org.eclipse.gef.ui.parts.GraphicalEditor.init(GraphicalEditor.java:350)
	at org.eclipse.jst.pagedesigner.ui.common.sash.SashEditorPart.addPage(SashEditorPart.java:90)
	at org.eclipse.jst.pagedesigner.editors.HTMLEditor$3.createPages(HTMLEditor.java:264)
	at org.eclipse.jst.pagedesigner.ui.common.sash.SashEditorPart.createPartControl(SashEditorPart.java:190)
	at org.eclipse.ui.part.MultiPageEditorPart.addPage(MultiPageEditorPart.java:244)
	at org.eclipse.ui.part.MultiPageEditorPart.addPage(MultiPageEditorPart.java:214)
	at org.eclipse.jst.pagedesigner.editors.HTMLEditor.sash_createAndAddDesignSourcePage(HTMLEditor.java:268)
	at org.eclipse.jst.pagedesigner.editors.HTMLEditor.createPages(HTMLEditor.java:439)
	at org.eclipse.ui.part.MultiPageEditorPart.createPartControl(MultiPageEditorPart.java:359)
	at org.eclipse.ui.internal.e4.compatibility.CompatibilityPart.createPartControl(CompatibilityPart.java:95)
	at org.eclipse.ui.internal.e4.compatibility.CompatibilityEditor.createPartControl(CompatibilityEditor.java:45)
	at org.eclipse.ui.internal.e4.compatibility.CompatibilityPart.create(CompatibilityPart.java:199)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
	at java.lang.reflect.Method.invoke(Unknown Source)
	at org.eclipse.e4.core.internal.di.MethodRequestor.execute(MethodRequestor.java:52)
	at org.eclipse.e4.core.internal.di.InjectorImpl.processAnnotated(InjectorImpl.java:828)
	at org.eclipse.e4.core.internal.di.InjectorImpl.processAnnotated(InjectorImpl.java:808)
	at org.eclipse.e4.core.internal.di.InjectorImpl.inject(InjectorImpl.java:108)
	at org.eclipse.e4.core.internal.di.InjectorImpl.internalMake(InjectorImpl.java:310)
	at org.eclipse.e4.core.internal.di.InjectorImpl.make(InjectorImpl.java:237)
	at org.eclipse.e4.core.contexts.ContextInjectionFactory.make(ContextInjectionFactory.java:153)
	at org.eclipse.e4.ui.internal.workbench.ReflectionContributionFactory.createFromBundle(ReflectionContributionFactory.java:90)
	at org.eclipse.e4.ui.internal.workbench.ReflectionContributionFactory.doCreate(ReflectionContributionFactory.java:64)
	at org.eclipse.e4.ui.internal.workbench.ReflectionContributionFactory.create(ReflectionContributionFactory.java:53)
	at org.eclipse.e4.ui.workbench.renderers.swt.ContributedPartRenderer.createWidget(ContributedPartRenderer.java:117)
	at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.createWidget(PartRenderingEngine.java:697)
	at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.createGui(PartRenderingEngine.java:496)
	at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.createGui(PartRenderingEngine.java:573)
	at org.eclipse.e4.ui.workbench.renderers.swt.StackRenderer.showTab(StackRenderer.java:512)
	at org.eclipse.e4.ui.workbench.renderers.swt.LazyStackRenderer$1.handleEvent(LazyStackRenderer.java:74)
	at org.eclipse.e4.ui.services.internal.events.UIEventHandler.handleEvent(UIEventHandler.java:41)
	at org.eclipse.equinox.internal.event.EventHandlerWrapper.handleEvent(EventHandlerWrapper.java:197)
	at org.eclipse.equinox.internal.event.EventHandlerTracker.dispatchEvent(EventHandlerTracker.java:197)
	at org.eclipse.equinox.internal.event.EventHandlerTracker.dispatchEvent(EventHandlerTracker.java:1)
	at org.eclipse.osgi.framework.eventmgr.EventManager.dispatchEvent(EventManager.java:230)
	at org.eclipse.osgi.framework.eventmgr.ListenerQueue.dispatchEventSynchronous(ListenerQueue.java:148)
	at org.eclipse.equinox.internal.event.EventAdminImpl.dispatchEvent(EventAdminImpl.java:135)
	at org.eclipse.equinox.internal.event.EventAdminImpl.sendEvent(EventAdminImpl.java:78)
	at org.eclipse.equinox.internal.event.EventComponent.sendEvent(EventComponent.java:39)
	at org.eclipse.e4.ui.services.internal.events.EventBroker.send(EventBroker.java:73)
	at org.eclipse.e4.ui.internal.workbench.UIEventPublisher.notifyChanged(UIEventPublisher.java:58)
	at org.eclipse.emf.common.notify.impl.BasicNotifierImpl.eNotify(BasicNotifierImpl.java:380)
	at org.eclipse.e4.ui.model.application.ui.impl.ElementContainerImpl.setSelectedElement(ElementContainerImpl.java:171)
	at org.eclipse.e4.ui.internal.workbench.ModelServiceImpl.showElementInWindow(ModelServiceImpl.java:287)
	at org.eclipse.e4.ui.internal.workbench.ModelServiceImpl.bringToTop(ModelServiceImpl.java:255)
	at org.eclipse.e4.ui.internal.workbench.PartServiceImpl.bringToTop(PartServiceImpl.java:264)
	at org.eclipse.e4.ui.internal.workbench.PartServiceImpl.showPart(PartServiceImpl.java:878)
	at org.eclipse.ui.internal.WorkbenchPage.busyOpenEditor(WorkbenchPage.java:2265)
	at org.eclipse.ui.internal.WorkbenchPage.access$14(WorkbenchPage.java:2227)
	at org.eclipse.ui.internal.WorkbenchPage$5.run(WorkbenchPage.java:2209)
	at org.eclipse.swt.custom.BusyIndicator.showWhile(BusyIndicator.java:70)
	at org.eclipse.ui.internal.WorkbenchPage.openEditor(WorkbenchPage.java:2205)
	at org.eclipse.ui.internal.WorkbenchPage.openEditor(WorkbenchPage.java:2189)
	at org.eclipse.ui.actions.OpenWithMenu.openEditor(OpenWithMenu.java:331)

java.lang.NullPointerException
	at org.eclipse.wst.sse.ui.internal.provisional.extensions.ConfigurationPointCalculator.getConfigurationPoints(ConfigurationPointCalculator.java:58)
	at org.eclipse.wst.sse.ui.internal.provisional.extensions.ConfigurationPointCalculator.getConfigurationPoints(ConfigurationPointCalculator.java:36)
	at org.eclipse.wst.sse.ui.StructuredTextEditor.getConfigurationPoints(StructuredTextEditor.java:2111)
	at org.eclipse.wst.sse.ui.StructuredTextEditor.createContentOutlineConfiguration(StructuredTextEditor.java:1420)
	at org.eclipse.wst.sse.ui.StructuredTextEditor.getAdapter(StructuredTextEditor.java:2020)
	at org.eclipse.jst.pagedesigner.editors.DesignerStructuredTextEditorJSP.getAdapter(DesignerStructuredTextEditorJSP.java:62)
	at org.eclipse.jst.pagedesigner.editors.HTMLEditor.getAdapter(HTMLEditor.java:639)
	at org.eclipse.ui.internal.views.ViewsPlugin.getAdapter(ViewsPlugin.java:103)
	at org.eclipse.ui.views.contentoutline.ContentOutline.doCreatePage(ContentOutline.java:131)
	at org.eclipse.ui.part.PageBookView.createPage(PageBookView.java:411)
	at org.eclipse.ui.part.PageBookView.partActivated(PageBookView.java:754)
	at org.eclipse.ui.views.contentoutline.ContentOutline.partBroughtToTop(ContentOutline.java:212)
	at org.eclipse.ui.part.PageBookView$4.partBroughtToTop(PageBookView.java:1039)
	at org.eclipse.ui.internal.WorkbenchPage$17.run(WorkbenchPage.java:3351)
	at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
	at org.eclipse.ui.internal.WorkbenchPage.firePartBroughtToTop(WorkbenchPage.java:3349)
	at org.eclipse.ui.internal.WorkbenchPage.access$10(WorkbenchPage.java:3334)
	at org.eclipse.ui.internal.WorkbenchPage$E4PartListener.partBroughtToTop(WorkbenchPage.java:147)
	at org.eclipse.e4.ui.internal.workbench.PartServiceImpl.firePartBroughtToTop(PartServiceImpl.java:202)
	at org.eclipse.e4.ui.internal.workbench.PartServiceImpl.access$3(PartServiceImpl.java:200)
	at org.eclipse.e4.ui.internal.workbench.PartServiceImpl$1.handleEvent(PartServiceImpl.java:85)
	at org.eclipse.e4.ui.services.internal.events.UIEventHandler.handleEvent(UIEventHandler.java:41)
	at org.eclipse.equinox.internal.event.EventHandlerWrapper.handleEvent(EventHandlerWrapper.java:197)
	at org.eclipse.equinox.internal.event.EventHandlerTracker.dispatchEvent(EventHandlerTracker.java:197)
	at org.eclipse.equinox.internal.event.EventHandlerTracker.dispatchEvent(EventHandlerTracker.java:1)
	at org.eclipse.osgi.framework.eventmgr.EventManager.dispatchEvent(EventManager.java:230)
	at org.eclipse.osgi.framework.eventmgr.ListenerQueue.dispatchEventSynchronous(ListenerQueue.java:148)
	at org.eclipse.equinox.internal.event.EventAdminImpl.dispatchEvent(EventAdminImpl.java:135)
	at org.eclipse.equinox.internal.event.EventAdminImpl.sendEvent(EventAdminImpl.java:78)
	at org.eclipse.equinox.internal.event.EventComponent.sendEvent(EventComponent.java:39)
	at org.eclipse.e4.ui.services.internal.events.EventBroker.send(EventBroker.java:73)
	at org.eclipse.e4.ui.internal.workbench.UIEventPublisher.notifyChanged(UIEventPublisher.java:58)
	at org.eclipse.emf.common.notify.impl.BasicNotifierImpl.eNotify(BasicNotifierImpl.java:380)
	at org.eclipse.e4.ui.model.application.ui.impl.ElementContainerImpl.setSelectedElement(ElementContainerImpl.java:171)
	at org.eclipse.e4.ui.internal.workbench.ModelServiceImpl.showElementInWindow(ModelServiceImpl.java:287)
	at org.eclipse.e4.ui.internal.workbench.ModelServiceImpl.bringToTop(ModelServiceImpl.java:255)
	at org.eclipse.e4.ui.internal.workbench.PartServiceImpl.bringToTop(PartServiceImpl.java:264)
	at org.eclipse.e4.ui.internal.workbench.PartServiceImpl.showPart(PartServiceImpl.java:878)
	at org.eclipse.ui.internal.WorkbenchPage.busyOpenEditor(WorkbenchPage.java:2265)
	at org.eclipse.ui.internal.WorkbenchPage.access$14(WorkbenchPage.java:2227)
	at org.eclipse.ui.internal.WorkbenchPage$5.run(WorkbenchPage.java:2209)
	at org.eclipse.swt.custom.BusyIndicator.showWhile(BusyIndicator.java:70)
	at org.eclipse.ui.internal.WorkbenchPage.openEditor(WorkbenchPage.java:2205)
	at org.eclipse.ui.internal.WorkbenchPage.openEditor(WorkbenchPage.java:2189)
	at org.eclipse.ui.actions.OpenWithMenu.openEditor(OpenWithMenu.java:331)

java.lang.NullPointerException
	at org.eclipse.wst.sse.ui.internal.provisional.extensions.ConfigurationPointCalculator.getConfigurationPoints(ConfigurationPointCalculator.java:58)
	at org.eclipse.wst.sse.ui.internal.provisional.extensions.ConfigurationPointCalculator.getConfigurationPoints(ConfigurationPointCalculator.java:36)
	at org.eclipse.wst.sse.ui.StructuredTextEditor.getConfigurationPoints(StructuredTextEditor.java:2111)
	at org.eclipse.wst.sse.ui.StructuredTextEditor.createContentOutlineConfiguration(StructuredTextEditor.java:1420)
	at org.eclipse.wst.sse.ui.StructuredTextEditor.getAdapter(StructuredTextEditor.java:2020)
	at org.eclipse.jst.pagedesigner.editors.DesignerStructuredTextEditorJSP.getAdapter(DesignerStructuredTextEditorJSP.java:62)
	at org.eclipse.jst.pagedesigner.editors.HTMLEditor.getAdapter(HTMLEditor.java:639)
	at org.eclipse.ui.internal.views.ViewsPlugin.getAdapter(ViewsPlugin.java:103)
	at org.eclipse.ui.views.contentoutline.ContentOutline.doCreatePage(ContentOutline.java:131)
	at org.eclipse.ui.part.PageBookView.createPage(PageBookView.java:411)
	at org.eclipse.ui.part.PageBookView.partActivated(PageBookView.java:754)
	at org.eclipse.ui.part.PageBookView$4.partActivated(PageBookView.java:1035)
	at org.eclipse.ui.internal.WorkbenchPage$9.run(WorkbenchPage.java:3228)
	at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
	at org.eclipse.ui.internal.WorkbenchPage.firePartActivated(WorkbenchPage.java:3226)
	at org.eclipse.ui.internal.WorkbenchPage.access$8(WorkbenchPage.java:3207)
	at org.eclipse.ui.internal.WorkbenchPage$E4PartListener.partActivated(WorkbenchPage.java:142)
	at org.eclipse.e4.ui.internal.workbench.PartServiceImpl.firePartActivated(PartServiceImpl.java:178)
	at org.eclipse.e4.ui.internal.workbench.PartServiceImpl.setPart(PartServiceImpl.java:152)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
	at java.lang.reflect.Method.invoke(Unknown Source)
	at org.eclipse.e4.core.internal.di.MethodRequestor.execute(MethodRequestor.java:52)
	at org.eclipse.e4.core.internal.contexts.ContextObjectSupplier$ContextInjectionListener.update(ContextObjectSupplier.java:75)
	at org.eclipse.e4.core.internal.contexts.TrackableComputationExt.update(TrackableComputationExt.java:88)
	at org.eclipse.e4.core.internal.contexts.EclipseContext.processScheduled(EclipseContext.java:326)
	at org.eclipse.e4.core.internal.contexts.EclipseContext.set(EclipseContext.java:343)
	at org.eclipse.e4.core.internal.contexts.EclipseContext.activate(EclipseContext.java:596)
	at org.eclipse.e4.core.internal.contexts.EclipseContext.activateBranch(EclipseContext.java:601)
	at org.eclipse.e4.ui.internal.workbench.PartActivationHistory.activate(PartActivationHistory.java:52)
	at org.eclipse.e4.ui.internal.workbench.PartServiceImpl.activate(PartServiceImpl.java:501)
	at org.eclipse.e4.ui.internal.workbench.PartServiceImpl.activate(PartServiceImpl.java:474)
	at org.eclipse.e4.ui.internal.workbench.PartServiceImpl.activate(PartServiceImpl.java:463)
	at org.eclipse.ui.internal.WorkbenchPage.busyOpenEditor(WorkbenchPage.java:2270)
	at org.eclipse.ui.internal.WorkbenchPage.access$14(WorkbenchPage.java:2227)
	at org.eclipse.ui.internal.WorkbenchPage$5.run(WorkbenchPage.java:2209)
	at org.eclipse.swt.custom.BusyIndicator.showWhile(BusyIndicator.java:70)
	at org.eclipse.ui.internal.WorkbenchPage.openEditor(WorkbenchPage.java:2205)
	at org.eclipse.ui.internal.WorkbenchPage.openEditor(WorkbenchPage.java:2189)
	at org.eclipse.ui.actions.OpenWithMenu.openEditor(OpenWithMenu.java:331)

Comment 1 Remy Suen

2011-01-13 14:02:47 EST

The JSF team seems to be implementing IEditorSite. This interface is marked as @noimplement and appears to be causing incompatibilities with Eclipse 4.1. It's not quite clear to me what the purpose of implementing this interface is.

Comment 2 Ian Trimble

2011-03-21 17:29:49 EDT

org.eclipse.jst.pagedesigner.ui.common.sash.SashEditorSite is the implementor of IEditorSite. This will need to be changed in the 4.x stream, but will require research and rework, as the interface has changed singificantly and our functionality will need to be provided in some other way.

This is not an issue in the 3.x stream - suggest we move to appropriate release.

Comment 3 Eric Moffatt

2011-09-22 20:10:21 EDT

Which interface does SashEditorSite implement and why ? 

I'm just tyring to determine whether there's a solution that will satisfy both environments. If the readon for the override shows a hole in the current API we may be able to 'promote' this to real API (for both streams).

Comment 4 Ian Trimble

2011-09-23 00:31:32 EDT

We implement IEditorSite, for historical reasons (and done by other contributors who no longer with the project) that would take considerable investigation to understand fully. We recently corrected the 4.x methods (hasService(...) and getService(...), from what I recall) and our editor now functions correctly in both streams. The reported exception is no longer thrown.

I think we're good now, and could close this, if the fact that we're implementing IEditorSite can be overlooked. If it can't, we need to leave this bug open until we can afford the resources to investigate and provide an alternative.

Comment 5 Eric Moffatt

2011-09-27 13:41:39 EDT

As per Ian's last comment...