Bug 334213

Comment 1 Szymon Brandys 2011-03-10 10:17:12 EST

I think we can use this bug for discussing Git Log UI. Susan, if you had something else in mind while filling the bug, let me know and I open a separate one for Git log UI.

Comment 2 libing wang 2011-03-10 10:32:59 EST

Also , we should be able to compare two versions in the history.

Comment 3 Susan McCourt 2011-03-10 10:58:36 EST

this is what I meant.

When I opened this bug, I also thought that the history list might be a good example of a visual component that could appear on it's own page or optionally embedded in nav page.  Not hard-coded in the page, but something that could test the idea of a "show view".  This was because we had so much real estate on the nav page that we are not using.

Comment 4 Susan McCourt 2011-03-10 13:13:05 EST

(In reply to comment #3)
> When I opened this bug, I also thought that the history list might be a good
> example of a visual component that could appear on it's own page or optionally
> embedded in nav page.  Not hard-coded in the page, but something that could
> test the idea of a "show view".  This was because we had so much real estate on
> the nav page that we are not using.

I think our approach in general for new UI is to build it as an independent component that lives on its own page.  So the git log is its own page, but through bug 339566 we can look at combinations of views.

Comment 5 John Arthorne 2011-03-10 17:03:24 EST

I agree we should start with a separate git log page for now. It would allow Compare with Latest or Each Other, and another action to checkout the selected revision (Replace With Revision).

Comment 6 Tomasz Zarna 2011-03-11 08:13:24 EST

(In reply to comment #0)
> it would be nice to show a generic file history 

I assume this means showing a git log for the selected path/folder and its children. You're not interested in seeing history for the repo[1], you want it to be narrowed to the selection, right?

> The use case is that I'd like to know from the Orion client that something has
> changed in a file and that I might need to go whatever tools are necessary to
> synch.

Well, that's a different story. To achieve that the server would need to fetch changes periodically and let you know there is something new on a remote. Sounds like a separate bug to me.

[1] http://git.eclipse.org/c/e4/org.eclipse.orion.server.git/log/

Comment 7 Tomasz Zarna 2011-03-11 08:17:17 EST

(In reply to comment #2)
> Also , we should be able to compare two versions in the history.

Opened bug 339682 for server API.

Comment 8 Boris Bokowski 2011-03-11 08:22:13 EST

(In reply to comment #6)
> I assume this means showing a git log for the selected path/folder and its
> children. You're not interested in seeing history for the repo[1], you want it
> to be narrowed to the selection, right?

I would like to see history for a single file, and history for the whole repository. History for a folder and its children is a nice to have as far as I am concerned.

Comment 9 Szymon Brandys 2011-03-11 11:58:33 EST

(In reply to comment #8)
Right, we start from implementing UI for a single file and the repository.

Comment 10 Susan McCourt 2011-03-14 11:19:52 EDT

(In reply to comment #6)

> > The use case is that I'd like to know from the Orion client that something has
> > changed in a file and that I might need to go whatever tools are necessary to
> > synch.
> 
> Well, that's a different story. To achieve that the server would need to fetch
> changes periodically and let you know there is something new on a remote.
> Sounds like a separate bug to me.

No, I didn't literally mean some kind of polling.  (This bug was written before we had git support or any idea of what it might look like).If I can see the history for a repo, I can see what's changed, that's good enough.

Comment 11 Szymon Brandys 2011-03-31 19:23:48 EDT

The Git Log UI is added. I will raise separate bugs for remaining issues.