Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 334212

Summary:	[client] editor color themes
Product:	[ECD] Orion	Reporter:	Susan McCourt <susan>
Component:	Editor	Assignee:	Anton McConville <antonm>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	antonm, caniszczyk, eclipse.felipe, mamacdon, Silenio_Quarti
Version:	0.2
Target Milestone:	2.0 RC1
Hardware:	PC
OS:	Windows 7
See Also:	https://bugs.eclipse.org/bugs/show_bug.cgi?id=347493
Whiteboard:

Description Susan McCourt

2011-01-12 23:53:57 EST

We need to ensure it's easy to support editor "themes" so that someone who wants to run a "light on dark" editor can do so.
Boris mentioned that we should look at digesting existing themes from other editors and producing the correct CSS for styling the code.
This also suggests a structured styling story - well defined CSS classes so that such things are possible.

I think there is an emerging syntax highlighting spec that might cover some of this.

Comment 1 Felipe Heidrich

2011-01-13 12:46:04 EST

I find the little demo in this page http://shjs.sourceforge.net/ pretty cool.

It would be great if we could re-use an existent Syntax Highlighter for JavaScript and just write a backend for our editor (and get Syntax Highlight for 100+ languages for free). I have looked at some options out there but:
- the license were incompatible with EPL
- no support for per-line styling or incremental changes (they were design for static text).

Comment 2 Felipe Heidrich

2011-11-24 12:15:49 EST

See https://bugs.eclipse.org/bugs/show_bug.cgi?id=363970#c9
We also added a minimal demonstration of this new support to textview demo.html

Susan, would you like to keep this problem open till support it added to at the editor level ?

Comment 3 Susan McCourt

2011-11-24 12:37:08 EST

(In reply to comment #2)
> See https://bugs.eclipse.org/bugs/show_bug.cgi?id=363970#c9
> We also added a minimal demonstration of this new support to textview demo.html
> 
> Susan, would you like to keep this problem open till support it added to at the
> editor level ?

I think so.  We need to explain the story for an Orion user to be able to feed their own color theme to the editor.  The "light on dark" is a good example.

Comment 4 Felipe Heidrich

2011-11-25 10:54:23 EST

(In reply to comment #3)
> (In reply to comment #2)
> I think so.  We need to explain the story for an Orion user to be able to feed
> their own color theme to the editor.  The "light on dark" is a good example.

See http://orion.eclipse.org/examples/textview/demo.html
At the bottom there is a Theme option that you can change to dark.
Note that the colors in there are horrible, the intend in the demo is just to test the feature.

The way I imagine the support in TextView gets extended to the Editor, then to EditorCommands (or something) so new themes can be imported to Orion as plugins.
There could be a preference page to allow the user to select among the available themes (preloaded+imported) and customize them.

Comment 5 Silenio Quarti

2012-09-28 14:40:09 EDT

Should we close this now that we have the Editor Themes in the Settings page?

Comment 6 Anton McConville

2013-02-07 13:29:37 EST

Think this is covered, now.