Bug 334196

Description Susan McCourt 2011-01-12 22:09:06 EST

In 0.2-M4, you can now use URL's such as:
http://localhost:8080/coding.html#file=/file/UGEcINDiAB8bJO_Yskwmnw/static/js/e4.js&line=89
http://localhost:8080/coding.html#file=/file/UGEcINDiAB8bJO_Yskwmnw/static/navigate-tree.html&char=4495,4508

These URL formats are inspired by
http://en.wikipedia.org/wiki/Fragment_identifier#Proposals
http://tools.ietf.org/html/rfc5147

Improvements:  
- It would be nice to be able to index within a line, such as
http://localhost:8080/coding.html#file=/file/UGEcINDiAB8bJO_Yskwmnw/static/js/e4.js&line=88&char=0,5

but I've got some bugs with indexing and some order dependencies and assumptions (that line must appear before char)
I need to do a better job of documenting how we handle conflicting parameters in this case.

- I did not implement ranges of lines (line=89,92) because we didn't need it yet.

- for the outliner, we need to support something like - go to line 88 and highlight the token "foo" on that line.  That one is kind of weird, because you need the editor model to figure out which line of text you are on.  So the code that constructs the URL would have to pass the token in the hash so that the editor could interpret it.  Maybe something like
http://localhost:8080/coding.html#file=/file/UGEcINDiAB8bJO_Yskwmnw/static/js/e4.js&line=88&highlight=foo
Until this is addressed, the outliner will position you to the right line, but won't highlight the method name as it did before

- the same kind of highlight token mentioned above is needed for the search use case:

(9:05:21 AM) johnart: susanmccourt: No, Lucene doesn't seem to provide line numbers, I spent a bit of time looking into it but didn't find a solution yet
(9:08:08 AM) johnart: Accurate line numbers for search is actually quite a difficult problem. We have a whole framework in eclipse for keeping that data correct as the document changes. A low tech solution would be to just search the individual document when it is opened in the editor.
(9:09:35 AM) johnart: For example a google search doesn't give you line numbers, you just have to search within the file after you open it...

So we should probably support
highlight=foo
- with no other params, just highlight the first found (as if a ctrl-f were done on that token)
- if a line number is also passed, the match is looked for in the line (the outliner case)
- if a char position (or range) is passed, the match is looked for using the range.