Bugzilla – Full Text Bug Listing
| Summary: | [MS Toolchain] Allow use of toolchain with only VS2008 installed | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Tools] CDT | Reporter: | Marc-André Laperle <malaperle> | ||||||
| Component: | cdt-build | Assignee: | Andrew Gvozdev <angvoz.dev> | ||||||
| Status: | CLOSED FIXED | QA Contact: | Andrew Gvozdev <angvoz.dev> | ||||||
| Severity: | enhancement | ||||||||
| Priority: | P3 | CC: | cdtdoug | ||||||
| Version: | 8.0 | ||||||||
| Target Milestone: | 8.0 | ||||||||
| Hardware: | PC | ||||||||
| OS: | Windows All | ||||||||
| Whiteboard: | |||||||||
| Attachments: |
|
||||||||
(In reply to comment #0) > This patch simply adds some null > checks to allow the variable supplier to complete its initialization process and > gather the variables even if the SDK is not found. Wouldn't it be sensible to quit right away if neither SDK nor VC found? The patch still updates the variables even if there is nothing to update. Created attachment 186701 [details]
MS Toolchain, VS2008 without WinSDK
Yes, thanks!
Committed on HEAD (8.0) with cosmetic changes. Thanks for the patch. I hope it's working as I don't have VS installed, please retest with new CDT build. I notice that I get VC toolchain in the list even if I do not have it on my system. We probably should detect existence using the same checks. *** cdt cvs genie on behalf of agvozdev *** bug 334194: [MS Toolchain] Allow use of toolchain with only VS2008 installed Patch from Marc-Andre Laperle [*] WinEnvironmentVariableSupplier.java 1.5 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/windows/org.eclipse.cdt.msw.build/src/org/eclipse/cdt/msw/build/WinEnvironmentVariableSupplier.java?root=Tools_Project&r1=1.4&r2=1.5 Cool. Thanks guys. Yes, we should support other combinations. (In reply to comment #3) > Committed on HEAD (8.0) with cosmetic changes. Thanks for the patch. I hope > it's working as I don't have VS installed, please retest with new CDT build. Yes, it's now working on my PC with VS2008 only, thank you! |
Created attachment 186699 [details] MS Toolchain, VS2008 without WinSDK Right now, the variable supplier looks for the Windows 7 SDK first and aborts if it doesn't find it. This prevents the toolchain from functioning properly when VS2008 is installed without the Windows 7 SDK. It is a common case that users will have VS2008 without the Windows SDK. This patch simply adds some null checks to allow the variable supplier to complete its initialization process and gather the variables even if the SDK is not found. In the future, I would also like to provide compatibility with VS2010 and VS Express without the Windows SDK installed.