Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 334092

Summary:	[server] For git file store use only JGit API
Product:	[ECD] Orion	Reporter:	Tomasz Zarna <tomasz.zarna>
Component:	Client	Assignee:	Tomasz Zarna <tomasz.zarna>
Status:	RESOLVED FIXED	QA Contact:
Severity:	enhancement
Priority:	P3	CC:	aniefer
Version:	0.2
Target Milestone:	0.2
Hardware:	PC
OS:	Windows XP
Whiteboard:
Bug Depends on:	330898, 335033
Bug Blocks:

Description Tomasz Zarna

2011-01-12 08:33:31 EST

When playing with git (GitFileStore) we should use only JGit (java implementation) API from org.eclipse.jgit. Since JGit's API is still shaping up this will require to use the most recent version of it.

One example is to replace CloneOperation from org.eclipse.egit.core and use CloneCommand from jgit once it's there (bug 330898). We should also consume all other useful commands which are in the org.eclipse.jgit.api package (like RmCommand for removing files).

Comment 1 Tomasz Zarna

2011-01-12 08:34:35 EST

Another method that could benefit from using JGit API is org.eclipse.filesystem.git.GitFileStore.rm() which should use org.eclipse.jgit.api.RmCommand.

Comment 2 Tomasz Zarna

2011-01-17 06:03:37 EST

*** Bug 334503 has been marked as a duplicate of this bug. ***

Comment 3 Tomasz Zarna

2011-01-26 06:24:48 EST

Blocking bug in JGit (bug 330898) most probably won't be fixed for M5. We have two options here: 
* roll out our own implementation of CloneOperation and keep it in o.e.orion.server.filesystem.git 
* wait for the blocker
* provide a patch to JGit

If the status of bug 330898 doesn't change in the nearest future I will try to propose a fix in M6.

Comment 4 Tomasz Zarna

2011-02-08 07:46:31 EST

Fixed with 6399f34b23ee5ff70762f1d8b57c5791140d553f.

Andrew, I simply removed entries for egit.core from orion.map and /org.eclipse.orion.server.feature/feature.xml. I hope this is enough and I didn't break anything.

Comment 5 Tomasz Zarna

2011-02-08 07:56:03 EST

(In reply to comment #1)
> Another method that could benefit from using JGit API is
> org.eclipse.filesystem.git.GitFileStore.rm() which should use
> org.eclipse.jgit.api.RmCommand.

Filed bug 336609.