Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 334085

Summary:	BrokenFileSystem and WrapperFileSystem refactoring
Product:	[Eclipse Project] Platform	Reporter:	Szymon Brandys <Szymon.Brandys>
Component:	Resources	Assignee:	Szymon Ptaszkiewicz <sptaszkiewicz>
Status:	RESOLVED WONTFIX	QA Contact:
Severity:	enhancement
Priority:	P3	CC:	jamesblackburn+eclipse
Version:	3.7
Target Milestone:	---
Hardware:	All
OS:	All
Whiteboard:
Bug Depends on:	332543
Bug Blocks:

Description Szymon Brandys

2011-01-12 08:14:17 EST

This came up to me while reviewing the fix for bug 332543.

James modified WrapperFileSystem so it could fail when the file store stream is closed. However we already have BrokenFileSystem and BrokenFileStore which was created to emulate errors in file stores. BrokenFileStore fails in other cases too though.

We could make BrokenFS more general, so it could be used in the James' test. Maybe other ideas?

Comment 1 James Blackburn

2011-01-12 08:21:02 EST

Or alternatively implement BrokenFS in terms of WrapperFS.

For regression tests it's useful to start from a working FS, introducing the suspect behaviour along with the test for handling the behaviour.  [BrokenFS starts from the other position: most operations fail...]

Comment 2 Szymon Brandys

2011-03-24 06:36:36 EDT

Moving to 3.8. Szymon P., feel free to move it back to 3.7, if you have time to fix it.

Comment 3 Szymon Ptaszkiewicz

2014-01-24 10:06:25 EST

I investigated this bug and the scope of work that would need to be done and I think the risk of corrupting existing tests it too big. Existing test file system implementations are tightly coupled with tests they were written for and changing them now could introduce unexpected bugs in tests. Closing as WONTFIX.