Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 334067

Summary: [browser]Avoid invoking _getUrl inside MapUrlToZone callback
Product: [Eclipse Project] Platform Reporter: wuzhe <wuzhe>
Component: SWTAssignee: Grant Gayed <grant_gayed>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: eclipse.felipe, kleind, mukund
Version: 3.6.1   
Target Milestone: 3.7 M5   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
patch
none
patch none

Description wuzhe CLA 2011-01-12 06:11:12 EST 
Build Identifier: 3.6.1

In side WebSite.java, MapUrlToZone callback invokes _getUrl() each time as part of the condition of whether is in setText mode. This will lower the performance. We can set a flag instead. Path provided as a reference.

Reproducible: Always
Comment 1 wuzhe CLA 2011-01-12 06:13:35 EST 
Created attachment 186613 [details]
patch

Patch.
Comment 2 Grant Gayed CLA 2011-01-12 10:53:05 EST 
Created attachment 186645 [details]
patch

That does get invoked a lot, attached is a revised patch.
Comment 3 Grant Gayed CLA 2011-01-12 10:54:18 EST 
fixed > 20110112
Comment 4 mukundan desikan CLA 2011-01-13 12:24:43 EST 
Grant

Will it be possible to fix this in  SWT 3.6.2 stream?
Comment 5 Grant Gayed CLA 2011-01-13 12:40:16 EST 
This is not appropriate for 3.6.2.  It's not an important enough fix (not a crash or functional regression), and there's not enough time to run with it in the 3.7 stream to gain confidence that there is not a regression being introduced.