Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 334051

Summary: Implement method sometimes doesn't add class name to methods in .cpp
Product: [Tools] CDT Reporter: Marc-André Laperle <malaperle>
Component: cdt-refactoringAssignee: Emanuel Graf <emanuel>
Status: RESOLVED FIXED QA Contact: Emanuel Graf <emanuel>
Severity: normal    
Priority: P3 CC: cdtdoug
Version: 8.0   
Target Milestone: 7.0.2   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
Implement method, qualified name patch
none
Implement method, qualified name patch emanuel: iplog+

Description Marc-André Laperle CLA 2011-01-11 19:14:08 EST 
CDT 8.0.0.201101051202

I can't attach the code to help reproduce the bug but here's an illustration:

Foo.h:

class Foo
{
  void bar();
};

Results in...

Foo.cpp:

void bar()
{

}

I will try to reproduce it with a simple code or attach a patch.
Comment 1 Marc-André Laperle CLA 2011-01-11 20:40:36 EST 
Created attachment 186588 [details]
Implement method, qualified name patch

checkFileNameAndLocation was only checking the first node location, nodes can have multiple locations.
Comment 2 Marc-André Laperle CLA 2011-01-11 20:42:45 EST 
Created attachment 186589 [details]
Implement method, qualified name patch

Oops, removed redundant boolean check.
Comment 3 Emanuel Graf CLA 2011-01-12 04:36:21 EST 
Fixed in 7.0 and HEAD > 20110112