Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 334048

Summary: [3.6.2] Clicking on a checkbox in a CheckboxTreeViewer selects the row.
Product: [Eclipse Project] Platform Reporter: Scott Kovatch <skovatch>
Component: SWTAssignee: Scott Kovatch <skovatch>
Status: RESOLVED FIXED QA Contact: Silenio Quarti <Silenio_Quarti>
Severity: normal    
Priority: P3 CC: darnells, prakash, riesem, skovatch
Version: 3.6.2Flags: Silenio_Quarti: review+
Target Milestone: 3.6.2   
Hardware: Macintosh   
OS: Mac OS X   
Whiteboard:
Bug Depends on: 329840    
Bug Blocks:    
Attachments:
Description Flags
3.6 branch fix none

Description Scott Kovatch CLA 2011-01-11 18:08:36 EST 
+++ This bug was initially created as a clone of Bug #329840 +++

Build Identifier: 20100617-1415

On Mac clicking on a checkbox in a CheckboxTreeViewer causes the corresponding row to be selected.

This does not happen on Windows. Also I could not find an Apple style guide that would require it to be like that. I think the behavior should be the same in this case.

P.s. I was not sure about the product and component and copied them form another bug related to the CheckboxTreeViewer.

Reproducible: Always

Steps to Reproduce:
1. Select an element in a CheckboxTreeViewer.
2. Click on the checkbox in a different row.
3. The selection changes.
Comment 1 Scott Kovatch CLA 2011-01-11 18:09:13 EST 
Nominating for 3.6.2.
Comment 2 Silenio Quarti CLA 2011-01-12 14:36:52 EST 
We need a patch for the R3_6_maintenance branch. The patch from bug#329840 does not apply clean.
Comment 3 Scott Kovatch CLA 2011-01-12 15:31:19 EST 
I'll attach the patch in a moment, but it would also pick up a fix for bug 325230 (disallow clearing of selection in SWT.SINGLE mode). It's easy to comment it out, but it also seems like a good fix to bring over as well.
Comment 4 Scott Kovatch CLA 2011-01-12 15:32:58 EST 
Created attachment 186673 [details]
3.6 branch fix
Comment 5 Silenio Quarti CLA 2011-01-12 17:24:25 EST 
The patch looks good to me. It is a kind of scary to release it in RC2, but I will +1 since it has been running in HEAD for a couple of months.
Comment 6 Scott Kovatch CLA 2011-01-13 01:29:55 EST 
Fixed in R3_6_maintenace > 20110113.