Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 334000

Summary:

Simple catalog manager

Product:

z_Archived

Reporter:

Gregoire Dupe <gdupe>

Component:

EMF-Facet

Assignee:

Gregoire Dupe <gdupe>

Status:

CLOSED FIXED

QA Contact:

Severity:

enhancement

Priority:

CC:

emft.facet-inbox, nicolas.guyomar

Version:

unspecified

Flags:

gdupe: indigo+

Target Milestone:

---

Hardware:

All

OS:

All

Whiteboard:

Bug Depends on:

Bug Blocks:

333553

Attachments:

Description	Flags
org.eclipse.emf.facet.common.core.catalog	none
org.eclipse.emf.facet.efacet.catalog	none
org.eclipse.emf.facet.efacet.catalog.tests	none
org.eclipse.emf.facet.efacet.core	none
org.eclipse.emf.facet.common.core	none
org.eclipse.emf.facet.common.core	gdupe: iplog+
org.eclipse.emf.facet.common.core.catalog	gdupe: iplog+
org.eclipse.emf.facet.util.emf.core plug-in	gdupe: iplog+

Description Gregoire Dupe

2011-01-11 11:39:30 EST

Hello,

AbstractEmfFacetCatalog comes with too many risks of bugs. We then need to replace the AbstractEmfFacetCatalog by a simple catalog manager which use EMF to store/represent its state and which only uses an extension point to declare the catalog entries (no builder).

Regards,
Gregoire Dupe

Comment 1 Nicolas Guyomar

2011-01-11 11:56:10 EST

Created attachment 186523 [details]
org.eclipse.emf.facet.common.core.catalog

The authors of the plugin org.eclipse.emf.facet.common.core.catalog are : 
Gregoire Dupe (Commiter)
Nicolas Guyomar

Comment 2 Nicolas Guyomar

2011-01-11 11:57:18 EST

Created attachment 186524 [details]
org.eclipse.emf.facet.efacet.catalog

The authors of the plugin org.eclipse.emf.facet.efacet.catalog are : 
Gregoire Dupe (Commiter)
Nicolas Guyomar

Comment 3 Nicolas Guyomar

2011-01-11 11:58:07 EST

Created attachment 186525 [details]
org.eclipse.emf.facet.efacet.catalog.tests

The author of org.eclipse.emf.facet.efacet.catalog.tests is : Nicolas Guyomar

Comment 4 Nicolas Guyomar

2011-01-11 11:58:46 EST

Created attachment 186526 [details]
org.eclipse.emf.facet.efacet.core

The authors of the plugin org.eclipse.emf.facet.efacet.core are : 
Gregoire Dupe (Commiter)
Nicolas Guyomar

Comment 5 Nicolas Guyomar

2011-01-11 11:59:50 EST

Created attachment 186527 [details]
org.eclipse.emf.facet.common.core

The authors of the patch org.eclipse.emf.facet.common.core are : 
Gregoire Dupe (Commiter)
Nicolas Guyomar

Comment 6 Nicolas Guyomar

2011-01-11 12:01:49 EST

Hi,

(a) I, Nicolas Guyomar, wrote 100% of the code I've provided in the plug-ins : 

 - org.eclipse.emf.facet.common.core.catalog
 - org.eclipse.emf.facet.efacet.catalog
 - org.eclipse.emf.facet.efacet.catalog.tests
 - org.eclipse.emf.facet.efacet.core

and in the patch : 
 -  - org.eclipse.emf.facet.common.core

(b) I have the right to contribute the code to Eclipse.
(c) I contribute the content under the EPL.


Regards

Nicolas Guyomar

Comment 7 Nicolas Guyomar

2011-01-12 03:47:46 EST

Comment on attachment 186524 [details]
org.eclipse.emf.facet.efacet.catalog

Moved to bug 333553

Comment 8 Nicolas Guyomar

2011-01-12 03:54:31 EST

Comment on attachment 186525 [details]
org.eclipse.emf.facet.efacet.catalog.tests

Moved to bug 333553

Comment 9 Nicolas Guyomar

2011-01-12 03:56:07 EST

Comment on attachment 186526 [details]
org.eclipse.emf.facet.efacet.core

Moved to bug 333553

Comment 10 Nicolas Guyomar

2011-01-12 05:25:56 EST

Created attachment 186606 [details]
org.eclipse.emf.facet.common.core

HI,

I have added documentation to the patch.

Regards

Nicolas Guyomar

Comment 11 Nicolas Guyomar

2011-01-12 05:28:11 EST

Created attachment 186607 [details]
org.eclipse.emf.facet.common.core.catalog

Hi, 

I have added some documentation to the plug-in.

Regards

Nicolas Guyomar

Comment 12 Gregoire Dupe

2011-01-12 11:52:58 EST

Comment on attachment 186607 [details]
org.eclipse.emf.facet.common.core.catalog

Here are contributions from an employee of Mia-Software, targeting future
Indigo release. The company has signed a Member Commiter Agreement. The
contribution does not need a CQ (see bug 322327).

Comment 13 Gregoire Dupe

2011-01-12 11:58:46 EST

Hello,

I've committed the plug-in org.eclipse.emf.facet.common.core.catalog. (Committed revision 191.)

Regards,
Gregoire Dupe

Comment 14 Gregoire Dupe

2011-01-13 08:03:00 EST

Comment on attachment 186606 [details]
org.eclipse.emf.facet.common.core

Hello,

I've committed this patch and added some copyright comments and documentations.

Committed revision 192.

Regards,
Gregoire

Comment 15 Gregoire Dupe

2011-01-13 09:31:37 EST

I've added the plug-in org.eclipse.emf.facet.common.core.catalog in the feature "org.eclipse.emf.facet.common.feature".

Committed revision 197.

Comment 16 Gregoire Dupe

2011-01-19 10:09:27 EST

Hi,

Catalog features have to be stored in a plug-in named org.eclipse.emf.facet.util.emf.core.

Regards,
Gregoire Dupe

Comment 17 Gregoire Dupe

2011-01-19 11:40:09 EST

Created attachment 187130 [details]
org.eclipse.emf.facet.util.emf.core plug-in

You can find in the attachment an archive of a new plug-in (org.eclipse.emf.facet.util.emf.core).

I've created this plug-in by coping existing code from EMF Facet.

Next step: remove the old version of the catalog framework and update the uses.

Regards,
Gregoire Dupe

Comment 18 Gregoire Dupe

2011-01-19 11:45:48 EST

Comment on attachment 187130 [details]
org.eclipse.emf.facet.util.emf.core plug-in

I've committed this plug-in.

Committed revision 228.

Comment 19 Gregoire Dupe

2011-01-19 11:49:58 EST

I've removed the old version of the catalog feature from org.eclipse.emf.facet.common.core and I’ve updated the uses of the catalog features.

Committed revision 229.

Next step: rename the plug-in org.eclipse.emf.facet.common.core.catalog to org.eclipse.emf.facet.util.emf.core.catalog.

Comment 20 Gregoire Dupe

2011-01-19 12:08:06 EST

I've added the plug-in "org.eclipse.emf.facet.util.emf.core" in the feature "org.eclipse.emf.facet.common".

Committed revision 233.

Comment 21 Gregoire Dupe

2011-01-20 07:21:52 EST

I've renamed the plug-in org.eclipse.emf.facet.common.core.catalog to
org.eclipse.emf.facet.util.emf.catalog.

Comment 22 Gregoire Dupe

2011-01-20 08:07:02 EST

To improve the API of the catalog feature, I’ve defined the eClass catalog::Catalog as an interface and moved the interface ICatalogManager to the package org.eclipse.emf.facet.util.emf.core.

Committed revision 241.

Comment 23 Gregoire Dupe

2011-06-06 11:29:42 EDT

This bug can be closed.