Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 333951

Summary:

[cdt] Integrate with CDT's reverse run control commands

Product:

[Tools] TCF

Reporter:

Anton Leherbauer <aleherb+eclipse>

Component:

Debug

Assignee:

Project Inbox <tcf.debug-inbox>

Status:

RESOLVED FIXED

QA Contact:

Severity:

enhancement

Priority:

CC:

eugene, marc.khouzam

Version:

unspecified

Target Milestone:

0.4.0

Hardware:

All

OS:

All

Whiteboard:

Bug Depends on:

290572

Bug Blocks:

Attachments:

Description	Flags
Integrate with CDT reverse run control support	none
Integrate with CDT reverse run control support (2)	cdtdoug: iplog-

Description Anton Leherbauer

2011-01-11 03:49:22 EST

CDT provides generic commands for reverse run control.  TCF should integrate with these commands instead of adding its own set of actions.  Patch follows.

Comment 1 Anton Leherbauer

2011-01-11 04:03:36 EST

Created attachment 186465 [details]
Integrate with CDT reverse run control support

This patch adds debug command handlers for CDT's reverese run control commands and removes the TCF action delegates.
Note that CDT's reverse run control additionally provides a toggle button to enable/disable reverse run control in the target.  The reverse run control toolbar buttons appear only when the button is checked.  For now this button is always checked and disabled for TCF contexts, because there is no API to enable/disable reverse run control (yet).
Note also that the fix for bug 290572 is required for this patch to work properly.  Otherwise the reverse run control buttons won't appear in the Debug view toolbar.

Comment 2 Marc Khouzam

2011-01-11 09:19:53 EST

Toni, isn't this 'reversed' in the patch :-)

TCFReverseResumeCommand extends BackOverCommand

TCFReverseStepOverCommand extends BackResumeCommand

Comment 3 Anton Leherbauer

2011-01-11 09:32:26 EST

Created attachment 186500 [details]
Integrate with CDT reverse run control support (2)

(In reply to comment #2)
> Toni, isn't this 'reversed' in the patch :-)
> 
> TCFReverseResumeCommand extends BackOverCommand
> 
> TCFReverseStepOverCommand extends BackResumeCommand

Thanks Marc! Silly typo.

Comment 4 Eugene Tarassov

2011-01-12 14:08:20 EST

Toni, you wrote:

> Note also that the fix for bug 290572 is required for this patch to work
> properly.  Otherwise the reverse run control buttons won't appear in the Debug
> view toolbar.

According to the comments in the bug 290572, it is fixed in CDT 7.0
I'm running CDT 7.0.1.201009141542, but reverse run control buttons are not visible. What version of CDT should I use for the patch to work?

Comment 5 Anton Leherbauer

2011-01-13 02:26:39 EST

(In reply to comment #4)
> According to the comments in the bug 290572, it is fixed in CDT 7.0
> I'm running CDT 7.0.1.201009141542, but reverse run control buttons are not
> visible. What version of CDT should I use for the patch to work?

The target milestone of the bug is 7.0.2, so you need a recent 7.0.2 build, e.g. from http://download.eclipse.org/tools/cdt/builds/7.0.2/I.I201101070605/index.html

Comment 6 Eugene Tarassov

2011-01-13 13:53:35 EST

It appears to work fine with recent 7.0.2 build.
I have committed the patch.
Thanks!