| Summary: | CDT PE Binary Parser does not recognize Borland compiled executable | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Tools] CDT | Reporter: | VT <eclipse.greatwolf> | ||||||
| Component: | cdt-core | Assignee: | Project Inbox <cdt-core-inbox> | ||||||
| Status: | NEW --- | QA Contact: | Jonah Graham <jonah> | ||||||
| Severity: | major | ||||||||
| Priority: | P3 | CC: | cdtdoug, malaperle | ||||||
| Version: | 8.0 | ||||||||
| Target Milestone: | --- | ||||||||
| Hardware: | PC | ||||||||
| OS: | Windows 7 | ||||||||
| Whiteboard: | |||||||||
| Attachments: |
|
||||||||
|
Description
VT
Can I get some response on this bug report? Hi, Looks like good investigation. Maybe you could try making a patch? http://wiki.eclipse.org/Getting_started_with_CDT_development I think the changes would be in the org.eclipse.cdt.core plugin, in the package org.eclipse.cdt.utils.coff or org.eclipse.cdt.utils.coff.parser And this bug probably belongs to Component : cdt-core :) Created attachment 186700 [details]
PE parser Borland patch
Knowing nothing about PE and just looking at the code...I just increased the hint buffer size and it works. Do you know what the exact hint buffer size should be? I don't want to just put a bigger number and hope for the best ;)
Actually, I have no idea what the hint buffer size is suppose to signify or represent. After looking through the documentation and COFF specs, I am unable to find what the max allowable value is for e_lfanew. Since this is a long type, 32-bit value on a typical i386 machine, I would guess e_lfanew could possibly be as high as 4,294,967,295(0xFFFF) -- though unlikely in practice for obvious reasons. I don't know how qualified I am to submit a patch fix for this though. I program primarily in C/C++ and I don't know any Java really. Add to this the fact that I don't even know the eclipse CDT codebase at all and you're asking for an impossible task. I can however test if your patch corrects the bug or not. But I'll need a way to get a build of eclipse with the patch applied somehow. Created attachment 223697 [details]
Test binary
Here's a test exe I compiled when I first look at this.
|