Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 333886

Summary: Port Tabbed Proerties View to RAP
Product: [RT] RAP Reporter: Gunnar Wagenknecht <gunnar>
Component: WorkbenchAssignee: Project Inbox <rap-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: enhancement    
Priority: P3 CC: austin.riddle, ralphgerbig, rsternberg, ruediger.herrmann
Version: 1.4   
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
patch for view.properties.tabbed
none
complete project none

Description Gunnar Wagenknecht CLA 2011-01-10 11:38:41 EST
Created attachment 186400 [details]
patch for view.properties.tabbed

The Eclipse workbench includes a tabbed properties view. It would be nice if this could be included in RAP.

Attached is a patch that simply renames the project from Eclipse CVS and customizes it to the missing RAP APIs.
Comment 1 Gunnar Wagenknecht CLA 2011-01-10 14:37:35 EST
Created attachment 186415 [details]
complete project

This attachment contains the complete project.
Comment 2 RĂ¼diger Herrmann CLA 2011-01-11 12:14:56 EST
I could imagine this plug-in (and eventually o.e.r.u.views) to become part of the RAP Incubator.
For the near future, the RAP core team does not have the resources to maintain a port of the tabbed properties view.  If you are willing to maintain the port, I would suggest you as a committer on the RAP Incubator project. 
What do you think?
Comment 3 Gunnar Wagenknecht CLA 2011-01-12 00:39:14 EST
Sounds like a plan. Do you produce a p2 repo from the incubator stuff?
Comment 4 Ralf Sternberg CLA 2011-01-12 06:22:36 EST
(In reply to comment #3)
> Sounds like a plan.

Cool!

> Do you produce a p2 repo from the incubator stuff?

Not yet. We currently consider moving our build to eclipse.org, once we succeeded with this, we could also set up a build for the incubator.
Comment 5 Benjamin Muskalla CLA 2011-01-12 08:03:20 EST
btw: I had some effort going on doing the same some while ago (https://github.com/bmuskalla/org.eclipse.rap.ui.views.properties.tabbed). If there is anything in my version you need for your code, just ping me and I'll contribute the patch.
Comment 6 Gunnar Wagenknecht CLA 2011-12-08 09:04:51 EST
What's the best CVS location to commit the code to?

org.eclipse.rap/incubator/ports/tabbed/org.eclipse.rap.ui.views.properties.tabbed
Comment 7 Austin Riddle CLA 2011-12-08 09:55:02 EST
(In reply to comment #6)
> What's the best CVS location to commit the code to?
> 
> org.eclipse.rap/incubator/ports/tabbed/org.eclipse.rap.ui.views.properties.tabbed

I would change "tabbed" to "tabbedprops".
Comment 8 RĂ¼diger Herrmann CLA 2011-12-08 10:36:21 EST
(In reply to comment #7)
> (In reply to comment #6)
> > What's the best CVS location to commit the code to?
> > 
> > org.eclipse.rap/incubator/ports/tabbed/org.eclipse.rap.ui.views.properties.tabbed
> 
> I would change "tabbed" to "tabbedprops".
+1 for "tabbedprops", "tabbed" is nice and short but too unspecific in my eyes.
Comment 9 Ralph Gerbig CLA 2012-03-06 08:33:51 EST
Hi all,

is this already in the CVS? I cannot find it.

Ralph
Comment 10 Gunnar Wagenknecht CLA 2012-03-06 09:27:42 EST
I just committed it.

org.eclipse.rap/incubator/ports/tabbedprops/org.eclipse.rap.ui.views.properties.tabbed
Comment 11 Gunnar Wagenknecht CLA 2012-03-06 09:28:20 EST
Committed.