Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 333843

Summary: each subclass of AbstractCatalogView saves column widths for all subclasses
Product: [Modeling] MoDisco Reporter: Nicolas Bros <nicolas.bros>
Component: InfrastructureAssignee: Nicolas Bros <nicolas.bros>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: hugo.bruneliere, modisco.web-inbox
Version: 0.9.0Flags: nicolas.bros: indigo+
Target Milestone: 0.9.0 M5   
Hardware: All   
OS: All   
Whiteboard:

Description Nicolas Bros CLA 2011-01-10 04:03:11 EST
Each subclass of AbstractCatalogView saves the whole map of column widths (shared by all subclasses), even though they don't use them.
Comment 1 Nicolas Bros CLA 2011-01-10 04:11:33 EST
This comes from the fact that COLUMN_WIDTHS is static. It was made static because we want to be able to save column widths during the session, instead of only when the workbench is closed (which is the case with ViewPart#saveState).
Comment 2 Nicolas Bros CLA 2011-01-10 09:13:26 EST
I fixed the problem, refactored AbstractCatalogView, created PersistableColumn to factor common functionality, and created wrappers for JFace columns that work for both tables and trees.

Committed in revision 3699.
Comment 3 Hugo Bruneliere CLA 2011-01-11 05:25:12 EST
Bug fixed.