Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 333834

Summary: JSFTestUtil produces different byte codes with new compiler due to unused variables
Product: [WebTools] Java Server Faces Reporter: David Williams <david_williams>
Component: CoreAssignee: Ian Trimble <ian.trimble>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: raghunathan.srinivasan
Version: unspecified   
Target Milestone: 3.2.3   
Hardware: PC   
OS: Windows 7   
See Also: https://git.eclipse.org/r/114264
https://git.eclipse.org/c/jsf/webtools.jsf.git/commit/?id=b4bade12201e9d370319b563692698894b42725b
Whiteboard:
Bug Depends on:    
Bug Blocks: 333678    
Attachments:
Description Flags
suggested fix none

Description David Williams CLA 2011-01-10 01:54:19 EST
Created attachment 186359 [details]
suggested fix

Similar to other bugs in 333678 ... there is an unused 'curPos' variable in loadFromInputStream that is optimized out with new compiler. 

I'd suggest fixing code (in maintenance stream and head) ... not sure what to recommend about version ... I didn't look to see if needs to be incremented or if it already has been ... but, patch attached to be explicit about unused variable.
Comment 1 Ian Trimble CLA 2011-01-10 18:58:30 EST
Patch committed to 3.3 stream at 2011/01/10 03:57PM PDT.
Comment 2 Ian Trimble CLA 2011-01-10 19:06:50 EST
Patch committed to 3.2.3 stream at 2011/01/10 04:06PM PDT.
Comment 3 Eclipse Genie CLA 2017-12-18 20:16:43 EST
New Gerrit change created: https://git.eclipse.org/r/114264