Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 333827

Summary: BindingColumnLayout has unused variables treated differently with new compiler
Product: [WebTools] WTP Webservices Reporter: David Williams <david_williams>
Component: wst.wsdlAssignee: David Williams <david_williams>
Status: RESOLVED FIXED QA Contact: Keith Chong <keith.chong.ca>
Severity: minor    
Priority: P3    
Version: unspecified   
Target Milestone: 3.3 M6   
Hardware: PC   
OS: Windows 7   
Whiteboard:
Bug Depends on:    
Bug Blocks: 333678    
Attachments:
Description Flags
patch to remove unused variables none

Description David Williams CLA 2011-01-10 00:10:09 EST
Created attachment 186350 [details]
patch to remove unused variables

related to bug 333678 ... 

This class has unused variable treated differently with new JDT compiler. Now correctly detected as "unused" are removed from byte code. 

But, this make the bundles have different bits, but same version and qualifier. 

I'd suggest in this case the code actually be fixed ... pretty clearly is not needed? The attached patch remove the variable and increments the service field by +1. Note, should be +100 if change made in only HEAD. (And, currently no plans to change compiler in maintenance ... normally a bad idea ... but, we might want to since that stream may be long lived).
Comment 1 David Williams CLA 2011-01-10 00:16:50 EST
I see now this class is already different in HEAD than maintenance, so no need to change 'service field' again, it already has been.
Comment 2 David Williams CLA 2011-02-26 19:05:28 EST
applied and released patch to remove unused variables from source