Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 333789

Summary:

Update to ASM 3.3.1

Product:

[Eclipse Project] Platform

Reporter:

Chris Aniszczyk <caniszczyk>

Component:

Releng

Assignee:

Kim Moir <kim.moir>

Status:

RESOLVED FIXED

QA Contact:

Severity:

enhancement

Priority:

CC:

ankur_sharma, curtis.windatt.public, kim.moir, Michael_Rennie, Olivier_Thomann

Version:

3.7

Target Milestone:

3.7 M7

Hardware:

OS:

Linux

Whiteboard:

Bug Depends on:

326128

Bug Blocks:

Attachments:

Description	Flags
patch	none

Description Chris Aniszczyk

2011-01-07 17:11:44 EST

Once Orbit contains the latest version of ASM, we should look at updating to it.

Comment 1 Michael Rennie

2011-01-10 10:54:37 EST

To decide if it is worth updating, ASM has a link to the differences from 3.2 (what we are currently using) to 3.3: http://asm.ow2.org/jdiff32to33/changes.html

The ASM page: http://asm.ow2.org/
The 3.3.x docs: http://asm.ow2.org/asm33/javadoc/user/index.html
The history (whats new sort of): http://asm.ow2.org/history.html

Comment 2 Chris Aniszczyk

2011-01-10 10:57:13 EST

ASM 3.3.1 is now approved.

Well, updating is generally the right thing to do (especially if other projects, like ECF, are moving up to the latest ASM). From the looks of it, it doesn't look like any API changed so we just have to do some testing on our end.

This should be a less PITA than Ant...

Comment 3 Michael Rennie

2011-01-10 12:13:04 EST

(In reply to comment #2)
> 
> This should be a less PITA than Ant...

lets hope so.

Comment 4 Chris Aniszczyk

2011-04-04 13:52:48 EDT

Any update on this?

The Fedora Linux project would appreciate moving to the latest version of ASM.

Comment 5 Michael Rennie

2011-04-04 14:30:48 EDT

(In reply to comment #4)
> Any update on this?
> 
> The Fedora Linux project would appreciate moving to the latest version of ASM.

We could have look at it for 3.7, but no promises.

Ankur, would you mind testing the update?

Comment 6 Olivier Thomann

2011-04-04 14:31:14 EDT

API tools bundles are referencing asm 3.2.0 up to 4.0.0.
So it should work straight forward with asm 3.3.1.

The first thing would be to update the orbit map entries:
# Orbit bundles for API tooling
plugin@org.objectweb.asm,3.3.1=p2IU,id=org.objectweb.asm,version=3.3.1.v200909071300,repository=http://download.eclipse.org/tools/orbit/downloads/drops/S20110304120314/repository
plugin@org.objectweb.asm.source,3.3.1=p2IU,id=org.objectweb.asm.source,version=3.3.1.v200909071300,repository=http://download.eclipse.org/tools/orbit/downloads/drops/S20110304120314/repository

to point to 3.3.1. And then try a test build.

Comment 7 Chris Aniszczyk

2011-04-04 14:48:07 EDT

Kim, can you do a test build for us with ASM 3.3.1?

Comment 8 Kim Moir

2011-04-05 08:07:24 EDT

I'll run one later this week, after we have an I-build.

Comment 9 Kim Moir

2011-04-05 12:54:20 EDT

Created attachment 192578 [details]
patch

Comment 10 Olivier Thomann

2011-04-05 13:16:39 EDT

Moving to Platform/Releng.
There is nothing to change to API Tools.

Comment 11 Olivier Thomann

2011-04-05 13:21:34 EDT

Ankur, we should still verify that everything works fine for API Tools once it consumes AST 3.3.1

Comment 12 Ankur Sharma

2011-04-05 13:28:24 EDT

Sure. I will do the testing as soon we have the build.

Comment 13 Chris Aniszczyk

2011-04-05 14:29:29 EDT

(In reply to comment #9)
> Created attachment 192578 [details]
> patch

Thanks Kim!

Comment 14 Kim Moir

2011-04-05 16:47:17 EDT

Fixed and tagged for I-build.

You're welcome Chris :-)

Comment 15 Kim Moir

2011-04-06 12:33:50 EDT

I've reverted this change for the I-build rebuild, I'll release it again tonight.

Comment 16 Chris Aniszczyk

2011-04-07 15:02:01 EDT

Did you release the new changes Kim?

Comment 17 Kim Moir

2011-04-07 20:10:17 EDT

Yes, Chris ASM 3.3.1 was released for N20110406-2000.