Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 333774

Summary: 'Result' view has strange coding pattern
Product: [Modeling] Acceleo Reporter: Remy Suen <remy.suen>
Component: CoreAssignee: Project Inbox <acceleo-inbox>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: stephane.begaudeau
Version: unspecified   
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard:

Description Remy Suen CLA 2011-01-07 12:52:21 EST
In the AcceleoResultView, a selection listener is attached to the returned value of PlatformUI.getWorkbench().getActiveWorkbenchWindow().getActivePage(). It's not clear to me why this is used when getSite().getPage() could just be used instead.

Also, if multiple views are opened and the user switches to another workbench window in between this action, the returned workbench page might not be the same workbench page as the one that the created view is in so now you're listening to selections from some other workbench window instead of your own.
Comment 1 Stephane Begaudeau CLA 2011-02-08 08:41:57 EST
Contributed on HEAD, it will be available in Acceleo 3.1.0 M6