Bugzilla – Full Text Bug Listing
| Summary: | MySQLPlatform.computeMaxRowsForSQL computes incorrect value | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | z_Archived | Reporter: | David Green <greensopinion> | ||||||
| Component: | Eclipselink | Assignee: | Nobody - feel free to take it <nobody> | ||||||
| Status: | CLOSED FIXED | QA Contact: | |||||||
| Severity: | major | ||||||||
| Priority: | P3 | CC: | clint.morgan, eclipselink.foundation-inbox, michael.f.obrien, tom.ware | ||||||
| Version: | unspecified | ||||||||
| Target Milestone: | --- | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| URL: | http://dev.mysql.com/doc/refman/5.5/en/select.html | ||||||||
| Whiteboard: | submitted_patch | ||||||||
| Attachments: |
|
||||||||
|
Description
David Green
Created attachment 186240 [details]
patch that fixes the problem
attached a patch that fixes the problem. Note that I wasn't able to run the test case.
Created attachment 186241 [details]
mylyn/context/zip
Setting target and priority. See the following page for the meanings of these fields: http://wiki.eclipse.org/EclipseLink/Development/Bugs/Guidelines A workaround for this issue is to provide your own subclass of the MySQLPlatform class:
bc.
public class MySQL55Platform extends MySQLPlatform {
@Override
public int computeMaxRowsForSQL(int firstResultIndex, int maxResults) {
// fix bug 333715 in superclass: see http://dev.mysql.com/doc/refman/5.5/en/select.html
return maxResults;
}
}
in your persistence.xml you can reference your platform as follows:
bc.
<property name="eclipselink.target-database" value="com.company.project.common.jpa.MySQL55Platform"/>
Investigating for 2.3.1 I do not see the described problem when I test.
here is my test:
EntityManager em = createEntityManager();
List results = em.createQuery("Select Object(Emp) from Employee Emp").setFirstResult(2).setMaxResults(5).getResultList();
When I run with current EclipseLink code, I get:
SELECT <selectFields> FROM CMP3_EMPLOYEE t1 LEFT OUTER JOIN CMP3_DEPT t0 ON (t0.ID = t1.DEPT_ID), CMP3_SALARY t2 WHERE (t2.EMP_ID = t1.EMP_ID) LIMIT ?, ?
bind => [2, 5]
When I run with the patch, I get:
SELECT <selectfields> FROM CMP3_EMPLOYEE t1 LEFT OUTER JOIN CMP3_DEPT t0 ON (t0.ID = t1.DEPT_ID), CMP3_SALARY t2 WHERE (t2.EMP_ID = t1.EMP_ID) LIMIT ?, ?
bind => [2, 7]
The current SQL is correct according to the quote above.
Please reopen if you can show me the bug here.
FYI: Your test case is setup using EclipseLink API rather than JPA API, as a result, the expectations are a little different. For backward compatility reasons maxRows ends up being firstIndex + maxRows. The reason for this is that in old versions of EclipseLink we used the JDBC constructs on Statement. In pure JDBC, to implement firstResult, you have to read a bunch or rows and then set the cursor within the result set. In order to give people expected numbers of results, we had to adjust by the number of first results. Now that we use LIMIT to get the values, there is likely some value in experimenting with how to line up these values a bit better, but that will require some JPA changes as well to ensure JPA queries function properly. I'll "unclose" this issue, but the patch will likely be more extensive than the one provided. I think this can be closed. I am working with David, and realized that we were calling @ReadQuery.setMaxRows@ with the *pageSize*. However it looks like that method expects the max result index (i.e., offset + pageSize). This mistake was an easy one to make because the jpa @Query.setMaxResults@ takes the page size. We have updated our usage of @ReadQuery@ and now no longer need the workaround that David suggests here. Closing based on feedback above. Thanks for catching this one Clint. The Eclipselink project has moved to Github: https://github.com/eclipse-ee4j/eclipselink |