Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 333693

Summary:	[ModelTooling] Add/Remove actions for child lists unfavourably placed
Product:	[Eclipse Project] e4	Reporter:	Matthias Basler <matthiasbasler>
Component:	UI	Assignee:	Project Inbox <e4.ui-inbox>
Status:	RESOLVED FIXED	QA Contact:
Severity:	trivial
Priority:	P3	CC:	tom.schindl
Version:	unspecified
Target Milestone:	4.1
Hardware:	All
OS:	All
Whiteboard:

Description Matthias Basler

2011-01-06 15:19:24 EST

Build Identifier: I20101216-1305

The e4 Workbenchmodel editor makes heavy use of widgets that allow to add, remove and re-order child elements. This widget has the buttons in the lower right corner, in the order Up, Down, Add, Remove.

1. The lists often have a rather large default height, up to 20 lines or so.
2. Such lists often appear in the lower part of the detail area, with the buttons being often outside the initally visible area.
3. The most important buttons (Add and Remove) are even at the end of the list.

The combination of these facts results in a lot of unnecessary scrolling on small screens like my notebook display (1280 x 800 only).

My suggestion is to have the buttons on the TOP right corner next to the list in the order "Add", "Remove", "Up" and "Down".

Reproducible: Always

Steps to Reproduce:
Does not apply.

Comment 1 Thomas Schindl

2011-01-28 19:52:28 EST

Now that we have the context menu in place the lists on the right are less important. It might also make sense to make them only 200px high (currently they are defined to use 300px). 

I've experimented a bit and move the buttons the top at least for me doesn't makes editor look worse. 

Do you agree that the useability issue is already solved because we are not providing a context menu on the tree?

Comment 2 Matthias Basler

2011-01-29 16:03:38 EST

@tom
Not sure I understand you completely, but in my opinion the issue is solved if
- either the buttons are aligned to the top of the list widget or
- the model tree has a context menu for adding/removing child items as you would usually do with the buttons next to the lists.

Since you mention that the latter has now be implemented this issue can be closed, imho. I'm going to test the next milestone and give feedback if things have improved.
Thanks.

Comment 3 Thomas Schindl

2011-03-30 18:12:24 EDT

There are the following changes:
a) The Tree has a context menu now
b) The Form Editor has been split into multiple Tabs and hence most time the 
   Buttons though still placed on the bottom are visible

Comment 4 Matthias Basler

2011-03-31 13:08:42 EDT

Yes, this solves the issue. Thank you.