Bugzilla – Full Text Bug Listing
| Summary: | [Dialogs] SWTExceptions when closing launch configuration dialog with the help up | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Remy Suen <remy.suen> | ||||
| Component: | Debug | Assignee: | Platform-Debug-Inbox <platform-debug-inbox> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | grkumar, markus.kell.r, Michael_Rennie, pawel.1.piech, susan | ||||
| Version: | 3.7 | Keywords: | contributed | ||||
| Target Milestone: | 3.7 M6 | ||||||
| Hardware: | PC | ||||||
| OS: | Windows XP | ||||||
| Whiteboard: | |||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 335996 | ||||||
| Attachments: |
|
||||||
|
Description
Remy Suen
I looked at this while trying to figure out bug 330587. I can't speak as to what is different about the run config dialog's widget tree that manifests this problem, but I see the problem. The dialog is in the middle of its dispose handling (because of the Esc key) and as part of this the tray gets closed. The tray sets the bounds of the shell, which forces a layout. Since the dialog is in the middle of being disposed, the layout fails. I think the solution here is to set the bounds in the async after the tray is closed. At this point, either the shell will be destroyed (and no layout required), or else the shell is still alive and then the bounds can be reset. Moving to platform UI to finish this up. Fixed in HEAD >20110111. No SWT error anymore. Toggling the tray (using the help button) still looks smooth and the layout is correct, so the async does not seem to harm the user experience. All of the UI and JFace tests still pass. Just to be clear. The proper/expected behavior is that the entire dialog should close when Esc is pressed, whether the help tray is open or not. This is what Remy observed with other dialogs, just not the launch config dialog. Now that the bug is fixed, the launch config dialog closes on Esc, whether the help tray is open or not. (In reply to comment #1) > I looked at this while trying to figure out bug 330587... Thank you, I honestly didn't know what to make of it. In I20110124-1800 PW This fix was bad, see bug 335996. I'll revert the bad fix, moving this bug to platform debug to fix the specific problem in the launch dialog. Created attachment 189026 [details] patch This is the patch Markus provided in bug 335996. This fix contains the part relevant to launch config dialog. applied patch to HEAD *** Bug 367189 has been marked as a duplicate of this bug. *** |