| Summary: | refactor jetty-jmx | ||
|---|---|---|---|
| Product: | [RT] Jetty | Reporter: | Greg Wilkins <gregw> |
| Component: | build | Assignee: | Hugues Malphettes <hmalphettes> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | jetty-inbox |
| Version: | 7.2.1 | ||
| Target Milestone: | 7.3.x | ||
| Hardware: | PC | ||
| OS: | All | ||
| Whiteboard: | |||
|
Description
Greg Wilkins
I've done the refactor, but broken the osgi module as a result. The jetty-jmx is now an optional dependency of modules like jetty-deploy and jetty-server. The osgi-boot already has jmx as optional, but the osgi tests are saying it cannot be resolved? tests are currently commented HELP! As commented on the jetty-dev mailing list:
the few modules that optionally depend on org.eclipse.jetty.jmx needed an extra instruction for the maven-bundle plugin to mark the corresponding import-package as optional.
The following was added to jetty-deploy, jetty-server and jetty-servlet.
I have not found other modules that need this modification but please do correct me if I missed another module that expose an MBean and depends on jetty-jmx for that reason.
<plugin>
<groupId>org.apache.felix</groupId>
<artifactId>maven-bundle-plugin</artifactId>
<version>${felix.bundle.version}</version>
<extensions>true</extensions>
<executions>
<execution>
<goals>
<goal>manifest</goal>
</goals>
<configuration>
<instructions>
<Import-Package>org.eclipse.jetty.jmx.*;version="[7.3,8)";resolution:=optional,*</Import-Package>
</instructions>
</configuration>
</execution>
</executions>
</plugin>
Fixed for 7.3.x with revision 2652 |