Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 333670

Summary:

Inconsistent behavior of getRevisionByVersion()

Product:

[Modeling] EMF

Reporter:

Egidijus Vaisnora <vaisegid>

Component:

cdo.core

Assignee:

Egidijus Vaisnora <vaisegid>

Status:

CLOSED FIXED

QA Contact:

Eike Stepper <stepper>

Severity:

normal

Priority:

CC:

saulius.tvarijonas

Version:

4.0

Flags:

stepper: review+

Target Milestone:

---

Hardware:

OS:

Mac OS X - Carbon (unsup.)

Whiteboard:

Attachments:

Description	Flags
Patch v1	none
Patch v2	none

Description Egidijus Vaisnora

2011-01-06 11:19:22 EST

Cloned from: 315043: Inconsistent behavior of getRevisionByVersion()
https://bugs.eclipse.org/bugs/show_bug.cgi?id=315043

Build Identifier: 3.0

getRevisionByVersion on detached revision returns null or DetachedCDORevision, regarding the local cache.
Expected result, to have method working the same way. 
Perhaps it is worth to consider return DetachedCDORevision for detached revision version and *null* for non existing version

Reproducible: Always

Steps to Reproduce:
test

Comment 1 Egidijus Vaisnora

2011-01-06 11:38:31 EST

Created attachment 186192 [details]
Patch v1

Adopted patch from the 3.0

Comment 2 Egidijus Vaisnora

2011-01-06 11:40:39 EST

Removed assignment

Comment 3 Egidijus Vaisnora

2011-01-06 11:42:10 EST

Ready for review

Comment 4 Eike Stepper

2011-01-08 10:46:02 EST

Created attachment 186327 [details]
Patch v2

Reformatted test.

Comment 5 Eike Stepper

2011-01-08 10:46:46 EST

Please commit patch v2 ;-)

Comment 6 Egidijus Vaisnora

2011-01-10 04:43:19 EST

Committed to HEAD

Comment 7 Eike Stepper

2011-06-23 03:40:26 EDT

Available in R20110608-1407